From: Vinod Koul <vinod.koul@intel.com>
To: Sam Van Den Berge <sam.van.den.berge@telenet.be>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
dmaengine@vger.kernel.org, k.kozlowski@samsung.com,
kgene@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices
Date: Thu, 15 Sep 2016 21:54:49 +0530 [thread overview]
Message-ID: <20160915162449.GY13920@localhost> (raw)
In-Reply-To: <2fa402bf-0e3f-0495-41ca-7a3c89eaa2e1@samsung.com>
On Thu, Sep 15, 2016 at 11:05:12AM +0200, Sylwester Nawrocki wrote:
> On 09/14/2016 08:29 PM, Sam Van Den Berge wrote:
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> ...
> > + { "3c2440-sdi", "rx", (void *)DMACH_SDI },
> > + { "3c2440-sdi", "tx", (void *)DMACH_SDI },
>
> The device names seem misspelled here, and looking at what
> drivers/mmc/host/s3cmci.c driver does we need just a single common
> entry for rx and tx
>
> { "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
>
> With this fixed feel free to add
And please change the title to dmaengine and NOT arm... I was about ti skip
this!
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices
Date: Thu, 15 Sep 2016 21:54:49 +0530 [thread overview]
Message-ID: <20160915162449.GY13920@localhost> (raw)
In-Reply-To: <2fa402bf-0e3f-0495-41ca-7a3c89eaa2e1@samsung.com>
On Thu, Sep 15, 2016 at 11:05:12AM +0200, Sylwester Nawrocki wrote:
> On 09/14/2016 08:29 PM, Sam Van Den Berge wrote:
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> ...
> > + { "3c2440-sdi", "rx", (void *)DMACH_SDI },
> > + { "3c2440-sdi", "tx", (void *)DMACH_SDI },
>
> The device names seem misspelled here, and looking at what
> drivers/mmc/host/s3cmci.c driver does we need just a single common
> entry for rx and tx
>
> { "s3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
>
> With this fixed feel free to add
And please change the title to dmaengine and NOT arm... I was about ti skip
this!
--
~Vinod
next prev parent reply other threads:[~2016-09-15 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160914183040eucas1p22a61e6b39333cfe1aa9a6b63e74a1bcf@eucas1p2.samsung.com>
2016-09-14 18:29 ` [PATCH] ARM: s3c24xx: Add dma_slave_map for s3c2440 devices Sam Van Den Berge
2016-09-14 18:29 ` Sam Van Den Berge
2016-09-15 9:05 ` Sylwester Nawrocki
2016-09-15 9:05 ` Sylwester Nawrocki
2016-09-15 16:24 ` Vinod Koul [this message]
2016-09-15 16:24 ` Vinod Koul
2016-09-15 9:26 ` Arnd Bergmann
2016-09-15 9:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915162449.GY13920@localhost \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sam.van.den.berge@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.