Doubts Regaarding the checkpatch.pl

Doubts Regaarding the checkpatch.pl

[Anchal Jain]

[-- Attachment #1.1: Type: text/plain, Size: 179 bytes --]

In checkpatch.pl tool only considers those patch which fixes the 
warning and errors. Those patch fixes the CHECK using checkpatch.pl 
tool. It is considered in the patch or not?

[-- Attachment #1.2: Type: text/html, Size: 246 bytes --]

Re: [Outreachy kernel] Doubts Regaarding the checkpatch.pl

[Greg KH]

On Thu, Sep 15, 2016 at 08:53:18AM -0700, Anchal Jain wrote:
> In checkpatch.pl tool only considers those patch which fixes the
> warning and errors.

What do you mean by this?

> Those patch fixes the CHECK using checkpatch.pl tool. It is considered
> in the patch or not?

I'm sorry, but I can not parse this, can you rephrase it?

thanks,

gre gk-h

Re: [Outreachy kernel] Doubts Regaarding the checkpatch.pl

[Anchal Jain]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

>I'm sorry, but I can not parse this, can you rephrase it?

When we run checkpatch.pl on our staging directory then it shows
- Errors
- Warnings
- Checks

So I want to know if we solve the check using checkpatch.pl tool then it is
consider in our patches
or Only those checks is consider which is solved using  *cocci* script
because this script also fixes those
checks

Thanks,


On Thu, Sep 15, 2016 at 10:08 PM, Greg KH <gregkh@linuxfoundation.org>
wrote:

> On Thu, Sep 15, 2016 at 08:53:18AM -0700, Anchal Jain wrote:
> > In checkpatch.pl tool only considers those patch which fixes the
> > warning and errors.
>
> What do you mean by this?
>
> > Those patch fixes the CHECK using checkpatch.pl tool. It is considered
> > in the patch or not?
>
> I'm sorry, but I can not parse this, can you rephrase it?
>
> thanks,
>
> gre gk-h
>

[-- Attachment #2: Type: text/html, Size: 1576 bytes --]

Re: [Outreachy kernel] Doubts Regaarding the checkpatch.pl

[Daniel Baluta]

On Thu, Sep 15, 2016 at 7:53 PM, Anchal Jain <anchalj109@gmail.com> wrote:
>
>>I'm sorry, but I can not parse this, can you rephrase it?
>
> When we run checkpatch.pl on our staging directory then it shows
> - Errors
> - Warnings
> - Checks
>
> So I want to know if we solve the check using checkpatch.pl tool then it is
> consider in our patches
> or Only those checks is consider which is solved using  cocci script because
> this script also fixes those
> checks

Can you give a real example for the CHECK? :)

Re: [Outreachy kernel] Doubts Regaarding the checkpatch.pl

[Anchal Jain]

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

> Can you give a real example for the CHECK? :)

like this

 CHECK: Unnecessary parentheses around padapter->mlmeextpriv
 CHECK: Please don't use multiple blank lines
 CHECK: Unnecessary parentheses around pstapriv->sta_hash_lock
 CHECK: Unnecessary parentheses around pstapriv->sta_hash_lock
 CHECK: Unnecessary parentheses around pmlmeext->mlmext_info
 CHECK: Concatenated strings should use spaces between elements


Thanks,

On Thu, Sep 15, 2016 at 10:44 PM, Daniel Baluta <daniel.baluta@gmail.com>
wrote:

> On Thu, Sep 15, 2016 at 7:53 PM, Anchal Jain <anchalj109@gmail.com> wrote:
> >
> >>I'm sorry, but I can not parse this, can you rephrase it?
> >
> > When we run checkpatch.pl on our staging directory then it shows
> > - Errors
> > - Warnings
> > - Checks
> >
> > So I want to know if we solve the check using checkpatch.pl tool then
> it is
> > consider in our patches
> > or Only those checks is consider which is solved using  cocci script
> because
> > this script also fixes those
> > checks
>
> Can you give a real example for the CHECK? :)
>

[-- Attachment #2: Type: text/html, Size: 1751 bytes --]

Re: [Outreachy kernel] Doubts Regaarding the checkpatch.pl

[Alison Schofield]

On Thu, Sep 15, 2016 at 11:02:50PM +0530, Anchal Jain wrote:
> > Can you give a real example for the CHECK? :)
> 
> like this
> 
>  CHECK: Unnecessary parentheses around padapter->mlmeextpriv
>  CHECK: Please don't use multiple blank lines
>  CHECK: Unnecessary parentheses around pstapriv->sta_hash_lock
>  CHECK: Unnecessary parentheses around pstapriv->sta_hash_lock
>  CHECK: Unnecessary parentheses around pmlmeext->mlmext_info
>  CHECK: Concatenated strings should use spaces between elements
> 
> 
> Thanks,
> 
> On Thu, Sep 15, 2016 at 10:44 PM, Daniel Baluta <daniel.baluta@gmail.com>
> wrote:
> 
> > On Thu, Sep 15, 2016 at 7:53 PM, Anchal Jain <anchalj109@gmail.com> wrote:
> > >
> > >>I'm sorry, but I can not parse this, can you rephrase it?
> > >
> > > When we run checkpatch.pl on our staging directory then it shows
> > > - Errors
> > > - Warnings
> > > - Checks
> > >
> > > So I want to know if we solve the check using checkpatch.pl tool then
> > it is
> > > consider in our patches
> > > or Only those checks is consider which is solved using  cocci script
> > because
> > > this script also fixes those
> > > checks

Here's my take, let me know if I got the question right?

Sometime the cocci script identifies and maybe also corrects (if you are using
the patch option) issues that were also found by checkpatch.  So, the
question perhaps is which tool you would mention in your log message?

I'd say both. You would say the issue was found and fixed with
coccinelle and also corrects checkpatch issue: ....

Or, maybe I don't have the question right ;)

alisons








> >
> > Can you give a real example for the CHECK? :)
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAAbeOSsVJn8Ed9B%2Bacg1BRXRnmixDouk9z1ijGy5LnU2isSz1w%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.

Re: [Outreachy kernel] Doubts Regaarding the checkpatch.pl

[Anchal Jain]

[-- Attachment #1: Type: text/plain, Size: 2928 bytes --]

>Here's my take, let me know if I got the question right?
>
>Sometime the cocci script identifies and maybe also corrects (if you are
using
>the patch option) issues that were also found by checkpatch.  So, the
>question perhaps is which tool you would mention in your log message?
>
>I'd say both. You would say the issue was found and fixed with
>coccinelle and also corrects checkpatch issue: ....
>
>Or, maybe I don't have the question right ;)



Yes, you are correct I am trying to ask that thing.

Thank you :-)

On Fri, Sep 16, 2016 at 10:20 AM, Alison Schofield <amsfield22@gmail.com>
wrote:

> On Thu, Sep 15, 2016 at 11:02:50PM +0530, Anchal Jain wrote:
> > > Can you give a real example for the CHECK? :)
> >
> > like this
> >
> >  CHECK: Unnecessary parentheses around padapter->mlmeextpriv
> >  CHECK: Please don't use multiple blank lines
> >  CHECK: Unnecessary parentheses around pstapriv->sta_hash_lock
> >  CHECK: Unnecessary parentheses around pstapriv->sta_hash_lock
> >  CHECK: Unnecessary parentheses around pmlmeext->mlmext_info
> >  CHECK: Concatenated strings should use spaces between elements
> >
> >
> > Thanks,
> >
> > On Thu, Sep 15, 2016 at 10:44 PM, Daniel Baluta <daniel.baluta@gmail.com
> >
> > wrote:
> >
> > > On Thu, Sep 15, 2016 at 7:53 PM, Anchal Jain <anchalj109@gmail.com>
> wrote:
> > > >
> > > >>I'm sorry, but I can not parse this, can you rephrase it?
> > > >
> > > > When we run checkpatch.pl on our staging directory then it shows
> > > > - Errors
> > > > - Warnings
> > > > - Checks
> > > >
> > > > So I want to know if we solve the check using checkpatch.pl tool
> then
> > > it is
> > > > consider in our patches
> > > > or Only those checks is consider which is solved using  cocci script
> > > because
> > > > this script also fixes those
> > > > checks
>
> Here's my take, let me know if I got the question right?
>
> Sometime the cocci script identifies and maybe also corrects (if you are
> using
> the patch option) issues that were also found by checkpatch.  So, the
> question perhaps is which tool you would mention in your log message?
>
> I'd say both. You would say the issue was found and fixed with
> coccinelle and also corrects checkpatch issue: ....
>
> Or, maybe I don't have the question right ;)
>
> alisons
>
>
>
>
>
>
>
>
> > >
> > > Can you give a real example for the CHECK? :)
> > >
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/
> msgid/outreachy-kernel/CAAbeOSsVJn8Ed9B%2Bacg1BRXRnmixDouk9z1ijGy5LnU2
> isSz1w%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
>

[-- Attachment #2: Type: text/html, Size: 4595 bytes --]