[PATCH v2] staging: lustre: Remove unnecessary return capture

[PATCH v2] staging: lustre: Remove unnecessary return capture

[Rehas Sachdeva]

Instead of storing the return value of a function call into a variable and
then returning it, we can club the two into a single return statement. This
change was made using the following semantic patch by Coccinelle:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
 drivers/staging/lustre/lustre/mdc/mdc_request.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c b/drivers/staging/lustre/lustre/mdc/mdc_request.c
index 5bf95f9..cf94926 100644
--- a/drivers/staging/lustre/lustre/mdc/mdc_request.c
+++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c
@@ -2488,9 +2488,8 @@ static int mdc_set_info_async(const struct lu_env *env,
 		}
 		spin_unlock(&imp->imp_lock);
 
-		rc = do_set_info_async(imp, MDS_SET_INFO, LUSTRE_MDS_VERSION,
-				       keylen, key, vallen, val, set);
-		return rc;
+		return do_set_info_async(imp, MDS_SET_INFO, LUSTRE_MDS_VERSION,
+					 keylen, key, vallen, val, set);
 	}
 	if (KEY_IS(KEY_SPTLRPC_CONF)) {
 		sptlrpc_conf_client_adapt(exp->exp_obd);
-- 
2.7.4

Re: [PATCH v2] staging: lustre: Remove unnecessary return capture

[Rehas Sachdeva]

[-- Attachment #1.1: Type: text/plain, Size: 1576 bytes --]

Please ignore this for v2 as i forgot to include the changelog.

On Friday, September 16, 2016 at 12:53:01 AM UTC+5:30, Rehas Sachdeva wrote:
>
> Instead of storing the return value of a function call into a variable and 
> then returning it, we can club the two into a single return statement. 
> This 
> change was made using the following semantic patch by Coccinelle: 
>
> @@ 
> local idexpression ret; 
> expression e; 
> @@ 
>
> -ret = 
> +return 
>      e; 
> -return ret; 
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com> 
> --- 
>  drivers/staging/lustre/lustre/mdc/mdc_request.c | 5 ++--- 
>  1 file changed, 2 insertions(+), 3 deletions(-) 
>
> diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
> b/drivers/staging/lustre/lustre/mdc/mdc_request.c 
> index 5bf95f9..cf94926 100644 
> --- a/drivers/staging/lustre/lustre/mdc/mdc_request.c 
> +++ b/drivers/staging/lustre/lustre/mdc/mdc_request.c 
> @@ -2488,9 +2488,8 @@ static int mdc_set_info_async(const struct lu_env 
> *env, 
>                  } 
>                  spin_unlock(&imp->imp_lock); 
>   
> -                rc = do_set_info_async(imp, MDS_SET_INFO, 
> LUSTRE_MDS_VERSION, 
> -                                       keylen, key, vallen, val, set); 
> -                return rc; 
> +                return do_set_info_async(imp, MDS_SET_INFO, 
> LUSTRE_MDS_VERSION, 
> +                                         keylen, key, vallen, val, set); 
>          } 
>          if (KEY_IS(KEY_SPTLRPC_CONF)) { 
>                  sptlrpc_conf_client_adapt(exp->exp_obd); 
> -- 
> 2.7.4 
>
>

[-- Attachment #1.2: Type: text/html, Size: 2272 bytes --]