Re: [Outreachy kernel] [PATCH 1/5] staging: slicoss: Fix alignment with open parentheses

[Rehas Sachdeva <aquannie@gmail.com>]

On Thu, Sep 15, 2016 at 09:20:12PM +0200, Julia Lawall wrote:
> 
> 
> On Fri, 16 Sep 2016, Rehas Sachdeva wrote:
> 
> > Align statements following a line with open parentheses to start after the '('.
> > Issue detected by checkpatch.pl.
> >
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > ---
> >  drivers/staging/slicoss/slicoss.c | 28 ++++++++++++++--------------
> >  1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> > index 21280a3..6bfb7a8 100644
> > --- a/drivers/staging/slicoss/slicoss.c
> > +++ b/drivers/staging/slicoss/slicoss.c
> > @@ -191,7 +191,7 @@ static void slic_timer_ping(ulong dev)
> >   *
> >   */
> >  static void slic_link_config(struct adapter *adapter,
> > -		      u32 linkspeed, u32 linkduplex)
> > +			     u32 linkspeed, u32 linkduplex)
> >  {
> >  	u32 speed;
> >  	u32 duplex;
> > @@ -707,7 +707,7 @@ static void slic_config_clear(struct adapter *adapter)
> >  }
> >
> >  static bool slic_mac_filter(struct adapter *adapter,
> > -			struct ether_header *ether_frame)
> > +			    struct ether_header *ether_frame)
> >  {
> >  	struct net_device *netdev = adapter->netdev;
> >  	u32 opts = adapter->macopts;
> > @@ -830,10 +830,10 @@ static void slic_timer_load_check(ulong cardaddr)
> >  }
> >
> >  static int slic_upr_queue_request(struct adapter *adapter,
> > -			   u32 upr_request,
> > -			   u32 upr_data,
> > -			   u32 upr_data_h,
> > -			   u32 upr_buffer, u32 upr_buffer_h)
> > +				  u32 upr_request,
> > +				  u32 upr_data,
> > +				  u32 upr_data_h,
> > +				  u32 upr_buffer, u32 upr_buffer_h)
> 
> Maybe you could put a few more arguments on the same line.  For example,
> since upr_buffer and upr_buffer_h are already on the same line, maybe you
> could do the same with upr_data and upr_data_h.
>

I see. I'll make the changes right away. Thanks for pointing out.

Rehas

> >  {
> >  	struct slic_upr *upr;
> >  	struct slic_upr *uprqueue;
> > @@ -899,19 +899,19 @@ static void slic_upr_start(struct adapter *adapter)
> >  }
> >
> >  static int slic_upr_request(struct adapter *adapter,
> > -		     u32 upr_request,
> > -		     u32 upr_data,
> > -		     u32 upr_data_h,
> > -		     u32 upr_buffer, u32 upr_buffer_h)
> > +			    u32 upr_request,
> > +			    u32 upr_data,
> > +			    u32 upr_data_h,
> > +			    u32 upr_buffer, u32 upr_buffer_h)
> 
> Likewise here.
> 
> julia
> 
> 
> >  {
> >  	unsigned long flags;
> >  	int rc;
> >
> >  	spin_lock_irqsave(&adapter->upr_lock, flags);
> >  	rc = slic_upr_queue_request(adapter,
> > -					upr_request,
> > -					upr_data,
> > -					upr_data_h, upr_buffer, upr_buffer_h);
> > +				    upr_request,
> > +				    upr_data,
> > +				    upr_data_h, upr_buffer, upr_buffer_h);
> >  	if (rc)
> >  		goto err_unlock_irq;
> >
> > @@ -1421,7 +1421,7 @@ retry:
> >  }
> >
> >  static void slic_cmdq_putdone_irq(struct adapter *adapter,
> > -				struct slic_hostcmd *cmd)
> > +				  struct slic_hostcmd *cmd)
> >  {
> >  	struct slic_cmdqueue *cmdq = &adapter->cmdq_done;
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a0e1623587ce0b842607142663aa65d7871245cc.1473966683.git.aquannie%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >