Re: [Outreachy kernel] [PATCH 3/5] staging: slicoss: Add {} to an arm of if-else

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Sep 16, 2016 at 12:45:05AM +0530, Rehas Sachdeva wrote:
> Adds braces {} to the if arm of an if-else statement which has braces {} on
> its else arm. This improves uniformity and readability. Issue detected by
> checkpatch.
> 
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
>  drivers/staging/slicoss/slicoss.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index f2c751c..8182e58 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -784,8 +784,9 @@ static void slic_timer_load_check(ulong cardaddr)
>  	if ((adapter) && (adapter->state == ADAPT_UP) &&
>  	    (card->state == CARD_UP) && (slic_global.dynamic_intagg)) {
>  		if (adapter->devid == SLIC_1GB_DEVICE_ID) {
> -			if (adapter->linkspeed == LINK_1000MB)
> +			if (adapter->linkspeed == LINK_1000MB) {
>  				level = 100;
> +			}
>  			else {

This line should be:
			} else {

thanks,

greg k-h