Re: [Qemu-devel] [PATCH v2 2/2] xen_platform: SUSE xenlinux unplug for emulated PCI

[Olaf Hering <olaf@aepfle.de>]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Wed, Sep 14, Stefano Stabellini wrote:

> The doc says:
> 
> "If VMDP was configured to control just NIC devices it would write the
> value 0x1 to offset 0x8. If VMDP was configured to control just storage
> devices it would write the value 0x2 to offset 0x8."
> 
> So 0x1 to 0x8 to unplug NICs, otherwise 0x2 to 0x8 to unplug storage.
> The switch above does the opposite. What am I missing? Am I misreading
> the document?

The doc is wrong, this is what qemu-trad does:

+    case 8:
+       if (val ==1 ) {
+               fprintf(logfile, "Disconnect IDE hard disk...\n");
+               ide_unplug_harddisks();
+               fprintf(logfile, "Done.\n");
+       } else if (val == 2) {
+               fprintf(logfile, "Disconnect netifs...\n");
+               pci_unplug_netifs();
+               fprintf(logfile, "Shutdown taps...\n");
+               net_tap_shutdown_all();
+               fprintf(logfile, "Done.\n");
+       }
+       break;

Olaf

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]