[PATCH] staging: iio: accel: Fix indentation

[PATCH] staging: iio: accel: Fix indentation

[Rehas Sachdeva]

This patch fixes the checkpatch.pl warning:
WARNING: Statements should start on a tabstop

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
index b5625f5..61f3241 100644
--- a/drivers/staging/iio/accel/sca3000_core.c
+++ b/drivers/staging/iio/accel/sca3000_core.c
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: iio: accel: Fix indentation

[Alison Schofield]

On Wed, Sep 14, 2016 at 10:59:24PM +0530, Rehas Sachdeva wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: Statements should start on a tabstop
> 
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>

Hi Rehas, 
This is a valid fix, but it was already submitted.
You wouldn't have easily known that.  

It's in iio git tree, not yet sync'd back to staging.
Not sure what the take-away or advice on this situation is.

Greg?

commit a5211b0d061644b48c80cfa1303413e79ace781e
Author: Clifton Barnes <clifton.a.barnes@gmail.com>
Date:   Mon Aug 22 22:45:05 2016 -0400
    staging: iio: accel: sca3000: remove extra space

alisons


> ---
>  drivers/staging/iio/accel/sca3000_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
> index b5625f5..61f3241 100644
> --- a/drivers/staging/iio/accel/sca3000_core.c
> +++ b/drivers/staging/iio/accel/sca3000_core.c
> @@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
>  		},						\
>  		.event_spec = &sca3000_event,			\
>  		.num_event_specs = 1,				\
> -	 }
> +	}
>  
>  static const struct iio_chan_spec sca3000_channels[] = {
>  	SCA3000_CHAN(0, IIO_MOD_X),
> -- 
> 2.7.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914172924.GA27415%40toblerone.
> For more options, visit https://groups.google.com/d/optout.

Re: [PATCH] staging: iio: accel: Fix indentation

[Rehas Sachdeva]

On Wed, Sep 14, 2016 at 07:33:23PM +0200, Lars-Peter Clausen wrote:
> Hi,
> 
> Thanks for the patch. Somebody else already send a patch for this a few
> weeks ago and the issue is no longer present in the IIO development tree.
>

Hi,

Thanks for letting me know. I'll take care next time.

> One comment on the subject line, it should include the driver name, e.g.
> like "staging: iio: sca3000: ...". Otherwise looks good.
>

Noted. Thank you.

Rehas

> - Lars
> 
> On 09/14/2016 07:29 PM, Rehas Sachdeva wrote:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: Statements should start on a tabstop
> > 
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > ---
> >  drivers/staging/iio/accel/sca3000_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
> > index b5625f5..61f3241 100644
> > --- a/drivers/staging/iio/accel/sca3000_core.c
> > +++ b/drivers/staging/iio/accel/sca3000_core.c
> > @@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
> >  		},						\
> >  		.event_spec = &sca3000_event,			\
> >  		.num_event_specs = 1,				\
> > -	 }
> > +	}
> >  
> >  static const struct iio_chan_spec sca3000_channels[] = {
> >  	SCA3000_CHAN(0, IIO_MOD_X),
> > 
> 

Re: [PATCH] staging: iio: accel: Fix indentation

[Rehas Sachdeva]

On Wed, Sep 14, 2016 at 07:43:35PM +0200, Hartmut Knaack wrote:
> Hi,
> additional to Lars-Peters comment, you would normally CC the linux-iio
> mailing list.
> Thanks,
> 
> Hartmut
> 
> Rehas Sachdeva schrieb am 14.09.2016 um 19:29:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: Statements should start on a tabstop
> > 
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > ---
> >  drivers/staging/iio/accel/sca3000_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
> > index b5625f5..61f3241 100644
> > --- a/drivers/staging/iio/accel/sca3000_core.c
> > +++ b/drivers/staging/iio/accel/sca3000_core.c
> > @@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
> >  		},						\
> >  		.event_spec = &sca3000_event,			\
> >  		.num_event_specs = 1,				\
> > -	 }
> > +	}
> >  
> >  static const struct iio_chan_spec sca3000_channels[] = {
> >  	SCA3000_CHAN(0, IIO_MOD_X),
> > 
>

Hi,
Point Noted. Thanks a lot.

Rehas

Re: [Outreachy kernel] [PATCH] staging: iio: accel: Fix indentation

[Greg Kroah-Hartman]

On Wed, Sep 14, 2016 at 10:47:16AM -0700, Alison Schofield wrote:
> On Wed, Sep 14, 2016 at 10:59:24PM +0530, Rehas Sachdeva wrote:
> > This patch fixes the checkpatch.pl warning:
> > WARNING: Statements should start on a tabstop
> > 
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> 
> Hi Rehas, 
> This is a valid fix, but it was already submitted.
> You wouldn't have easily known that.  
> 
> It's in iio git tree, not yet sync'd back to staging.
> Not sure what the take-away or advice on this situation is.
> 
> Greg?

I was behind in syncing up with the iio tree, that's now taken care of,
sorry.

greg k-h