* [PATCH] staging: xgifb: Replace explicit NULL comparison
@ 2016-09-15 21:12 Namrata A Shettar
2016-09-16 8:26 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Namrata A Shettar @ 2016-09-15 21:12 UTC (permalink / raw)
To: outreachy-kernel, Arnaud Patard, Greg Kroah-Hartman,
Clifton Barnes, Geliang Tang, Ben Marsh, Janani Ravichandran,
Benoit Hiller
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
Replace explicit NULL comparison with equivalent expression to resolve
checkpatch issue.
- x != NULL => x
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index d56ef14..23a3bd7 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -2085,7 +2085,7 @@ static int __init xgifb_init(void)
{
char *option = NULL;
- if (forcecrt2type != NULL)
+ if (forcecrt2type)
XGIfb_search_crt2type(forcecrt2type);
if (fb_get_options("xgifb", &option))
return -ENODEV;
[-- Attachment #2: Type: text/html, Size: 1024 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: xgifb: Replace explicit NULL comparison
2016-09-15 21:12 [PATCH] staging: xgifb: Replace explicit NULL comparison Namrata A Shettar
@ 2016-09-16 8:26 ` Greg Kroah-Hartman
2016-09-16 9:51 ` Namrata A Shettar
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-16 8:26 UTC (permalink / raw)
To: Namrata A Shettar
Cc: outreachy-kernel, Arnaud Patard, Clifton Barnes, Geliang Tang,
Ben Marsh, Janani Ravichandran, Benoit Hiller
On Fri, Sep 16, 2016 at 02:42:18AM +0530, Namrata A Shettar wrote:
> Replace explicit NULL comparison� with equivalent expression to resolve
> checkpatch issue.
> - x != NULL => x
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> �drivers/staging/xgifb/XGI_main_26.c | 2 +-
> �1 file changed, 1 insertion(+), 1 deletion(-)
You sent this as an html email, and that will not work for patches,
sorry.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: xgifb: Replace explicit NULL comparison
2016-09-16 8:26 ` Greg Kroah-Hartman
@ 2016-09-16 9:51 ` Namrata A Shettar
0 siblings, 0 replies; 3+ messages in thread
From: Namrata A Shettar @ 2016-09-16 9:51 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: outreachy-kernel
Yes,will keep that in mind and use some other mail-agent.Will resend all
my patches.Thanks for being patient and sorry for the inconvenience
caused.
-Namrata
On Fri, Sep 16, 2016 at 10:26:41AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 16, 2016 at 02:42:18AM +0530, Namrata A Shettar wrote:
> > Replace explicit NULL comparison� with equivalent expression to resolve
> > checkpatch issue.
> > - x != NULL => x
> >
> > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > ---
> > �drivers/staging/xgifb/XGI_main_26.c | 2 +-
> > �1 file changed, 1 insertion(+), 1 deletion(-)
>
> You sent this as an html email, and that will not work for patches,
> sorry.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-16 9:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15 21:12 [PATCH] staging: xgifb: Replace explicit NULL comparison Namrata A Shettar
2016-09-16 8:26 ` Greg Kroah-Hartman
2016-09-16 9:51 ` Namrata A Shettar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.