From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
Date: Fri, 16 Sep 2016 10:41:21 +0200 [thread overview]
Message-ID: <20160916084121.GC2415@lst.de> (raw)
In-Reply-To: <accff9a7a1b04cdb8fc364851f20b93e3de0d7f0.1474002926.git.luto@kernel.org>
On Thu, Sep 15, 2016@10:24:20PM -0700, Andy Lutomirski wrote:
> Any user I can imagine that needs a buffer at all will want to pass
> a pointer directly. There are no currently callers that use
> buffers, so this change is painless, and it will make it much easier
> to start using features that use buffers (e.g. APST).
>
> Signed-off-by: Andy Lutomirski <luto at kernel.org>
> ---
Looks good mostly good, but a nitpick below:
> + /*
> + * Casting buffer to void* is safe here: __nvme_submit_sync_cmd knows
> + * that we're writing because it decodes the opcode.
> + */
> + ret = __nvme_submit_sync_cmd(dev->admin_q, &c, &cqe,
> + (void *)buffer, buflen, 0, NVME_QID_ANY, 0, 0);
Cant we just drop the const annotation to avoid these casts?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andy Lutomirski <luto@kernel.org>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org,
J Freyensee <james_p_freyensee@linux.intel.com>
Subject: Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()
Date: Fri, 16 Sep 2016 10:41:21 +0200 [thread overview]
Message-ID: <20160916084121.GC2415@lst.de> (raw)
In-Reply-To: <accff9a7a1b04cdb8fc364851f20b93e3de0d7f0.1474002926.git.luto@kernel.org>
On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote:
> Any user I can imagine that needs a buffer at all will want to pass
> a pointer directly. There are no currently callers that use
> buffers, so this change is painless, and it will make it much easier
> to start using features that use buffers (e.g. APST).
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
Looks good mostly good, but a nitpick below:
> + /*
> + * Casting buffer to void* is safe here: __nvme_submit_sync_cmd knows
> + * that we're writing because it decodes the opcode.
> + */
> + ret = __nvme_submit_sync_cmd(dev->admin_q, &c, &cqe,
> + (void *)buffer, buflen, 0, NVME_QID_ANY, 0, 0);
Cant we just drop the const annotation to avoid these casts?
next prev parent reply other threads:[~2016-09-16 8:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 5:24 [PATCH v3 0/3] nvme power saving Andy Lutomirski
2016-09-16 5:24 ` Andy Lutomirski
2016-09-16 5:24 ` [PATCH v3 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-09-16 5:24 ` Andy Lutomirski
2016-09-16 8:33 ` Christoph Hellwig
2016-09-16 8:33 ` Christoph Hellwig
2016-09-16 14:33 ` Keith Busch
2016-09-16 14:33 ` Keith Busch
2016-09-16 14:25 ` Christoph Hellwig
2016-09-16 14:25 ` Christoph Hellwig
2016-09-19 7:59 ` Johannes Thumshirn
2016-09-19 7:59 ` Johannes Thumshirn
2016-09-16 23:33 ` J Freyensee
2016-09-16 23:33 ` J Freyensee
2016-09-16 5:24 ` [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-09-16 5:24 ` Andy Lutomirski
2016-09-16 8:41 ` Christoph Hellwig [this message]
2016-09-16 8:41 ` Christoph Hellwig
2016-09-16 15:13 ` Andy Lutomirski
2016-09-16 15:13 ` Andy Lutomirski
2016-09-16 15:34 ` Jens Axboe
2016-09-16 15:34 ` Jens Axboe
2016-09-16 5:24 ` [PATCH v3 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-09-16 5:24 ` Andy Lutomirski
2016-09-16 8:42 ` Christoph Hellwig
2016-09-16 8:42 ` Christoph Hellwig
2016-09-16 15:14 ` Andy Lutomirski
2016-09-16 15:14 ` Andy Lutomirski
2016-09-16 16:51 ` Christoph Hellwig
2016-09-16 16:51 ` Christoph Hellwig
2016-09-16 15:38 ` Keith Busch
2016-09-16 15:38 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916084121.GC2415@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.