Re: [PATCH 3/5] staging: sm750fb: Remove multiple assignments

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Sep 16, 2016 at 06:04:39PM +0530, Rehas Sachdeva wrote:
> On Fri, Sep 16, 2016 at 09:48:59AM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 16, 2016 at 03:03:02AM +0530, Rehas Sachdeva wrote:
> > > Fixes multiple assignments of the form 'x = y = k' to 'x = k; y = k;'. Issue
> > > detected by checkpatch.
> > > 
> > > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > > ---
> > >  drivers/staging/sm750fb/sm750.c | 12 ++++++++----
> > >  1 file changed, 8 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> > > index 7d90e25..9f1b591 100644
> > > --- a/drivers/staging/sm750fb/sm750.c
> > > +++ b/drivers/staging/sm750fb/sm750.c
> > > @@ -365,7 +365,8 @@ static int lynxfb_ops_set_par(struct fb_info *info)
> > >  		ret = -EINVAL;
> > >  		break;
> > >  	}
> > > -	var->height = var->width = -1;
> > > +	var->height = -1;
> > > +	var->width = -1;
> > 
> > that's an odd change, isn't the first version of all of these more
> > readable?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi Greg,
> 
> This is an odd change indeed, something I saw only in sm750fb, among so many
> other drivers. Does that mean that for the sake of uniformity, we should go
> ahead with this? Although the first version looks better somehow.

I recommend just leaving it alone, thanks.

greg k-h