From: Greg KH <gregkh@linuxfoundation.org>
To: sayli karnik <karniksayli1995@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2 4/6] staging: ks7010: Remove unnecessary blank lines
Date: Fri, 16 Sep 2016 16:05:28 +0200 [thread overview]
Message-ID: <20160916140528.GA391@kroah.com> (raw)
In-Reply-To: <78d72b736673b2c871b591b694e8cbee35056f93.1474032241.git.karniksayli1995@gmail.com>
On Fri, Sep 16, 2016 at 07:20:37PM +0530, sayli karnik wrote:
> The patch removes unnecessary blank lines as detected by checkpatch.pl.
>
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
> v2: Code under comments removed as suggested by Julia.
>
> drivers/staging/ks7010/ks7010_sdio.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b0c6f93..bee7504 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -180,8 +180,6 @@ int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
>
> if (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
> (priv->connect_status & CONNECT_STATUS_MASK) == CONNECT_STATUS) {
> -
> - //DPRINTK(1,"psstatus.status=%d\n",atomic_read(&priv->psstatus.status));
That is not a "unnecessary blank line" :(
Please update your changelog text when you do something else in the
patch...
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-16 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 13:44 [PATCH v2 0/6] staging: ks7010: Fix multiple checkpatch warnings sayli karnik
2016-09-16 13:45 ` [PATCH v2 1/6] staging: ks7010: Use #include <linux/atomic.h> instead of <asm/atomic.h> sayli karnik
2016-09-17 21:31 ` [PATCH v3 " Greg KH
2016-09-16 13:48 ` [PATCH v2 2/6] staging: ks7010: Remove braces following single statement blocks sayli karnik
2016-09-18 11:02 ` [Outreachy kernel] [PATCH v3 " Julia Lawall
2016-09-18 19:19 ` sayli karnik
2016-09-19 9:49 ` Julia Lawall
2016-09-16 13:49 ` [PATCH v2 3/6] staging: ks7010: Remove space after '(' and before ')' sayli karnik
2016-09-16 13:50 ` [PATCH v2 4/6] staging: ks7010: Remove unnecessary blank lines sayli karnik
2016-09-16 14:05 ` Greg KH [this message]
2016-09-16 14:24 ` sayli karnik
2016-09-16 13:51 ` [PATCH v2 5/6] staging: ks7010: Remove the space after a type cast sayli karnik
2016-09-16 13:52 ` [PATCH v2 6/6] staging: ks7010: Remove extra round braces around expressions/variables sayli karnik
2016-09-18 7:10 ` [Outreachy kernel] [PATCH v3 0/6] staging: ks7010: Fix multiple checkpatch warnings Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916140528.GA391@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=karniksayli1995@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.