[PATCH v2 0/6] staging: ks7010: Fix multiple checkpatch warnings

[PATCH v2 0/6] staging: ks7010: Fix multiple checkpatch warnings

[sayli karnik]

This patchset fixes several checkpatch issues detected in the ks7010_sdio.c
file of the ks7010 driver. 

Changes in v2:
Corrected the subject line
Added a patch to remove extra braces
Removed code under comments in patch 3/6

sayli karnik (6):
  Use #include <linux/atomic.h> instead of <asm/atomic.h>
  Remove braces following single statement blocks
  Remove space after '(' and before ')'
  Remove unnecessary blank lines
  Remove the space after a type cast
  Remove extra round braces around expressions/variables

 drivers/staging/ks7010/ks7010_sdio.c | 63 ++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 35 deletions(-)

-- 
2.7.4

[PATCH v2 1/6] staging: ks7010: Use #include <linux/atomic.h> instead of <asm/atomic.h>

[sayli karnik]

This patch replaces <asm/atomic.h> with <linux/atomic.h>, as suggested
by checkpatch.pl.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index d5299f0..b993804 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -14,7 +14,7 @@
 #include <linux/mmc/card.h>
 #include <linux/mmc/sdio_func.h>
 #include <linux/workqueue.h>
-#include <asm/atomic.h>
+#include <linux/atomic.h>
 
 #include "ks_wlan.h"
 #include "ks_wlan_ioctl.h"
-- 
2.7.4

Re: [PATCH v3 1/6] staging: ks7010: Use #include <linux/atomic.h> instead of <asm/atomic.h>

[Greg KH]

On Fri, Sep 16, 2016 at 08:14:49PM +0530, sayli karnik wrote:
> This patch replaces <asm/atomic.h> with <linux/atomic.h>, as suggested
> by checkpatch.pl.
> 
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

One patch here says "v3" yet others say "v2", so they can't be sorted in
order :(

Please fix up the series, make them all the same version (as they are),
and resend the whole thing.

thanks,

greg k-h

[PATCH v2 2/6] staging: ks7010: Remove braces following single statement blocks

[sayli karnik]

The patch removes braces {} for single statement blocks, as suggested by
checkpatch.pl.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 38 +++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index b993804..8e1f68a 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -157,9 +157,9 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv)
 		rw_data = WAKEUP_REQ;
 		retval =
 		    ks7010_sdio_write(priv, WAKEUP, &rw_data, sizeof(rw_data));
-		if (retval) {
+		if (retval)
 			DPRINTK(1, " error : WAKEUP=%02X\n", rw_data);
-		}
+
 		DPRINTK(4, "wake up : WAKEUP=%02X\n", rw_data);
 		priv->last_wakeup = jiffies;
 		++priv->wakeup_count;
@@ -398,9 +398,8 @@ static void rx_event_task(unsigned long dev)
 		hostif_receive(priv, rp->data, rp->size);
 		inc_rxqhead(priv);
 
-		if (cnt_rxqbody(priv) > 0) {
+		if (cnt_rxqbody(priv) > 0)
 			tasklet_schedule(&priv->ks_wlan_hw.rx_bh_task);
-		}
 	}
 }
 
@@ -426,9 +425,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 	retval =
 	    ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
 			     hif_align_size(size));
-	if (retval) {
+	if (retval)
 		goto error_out;
-	}
 
 	/* length check */
 	if (size > 2046 || size == 0) {
@@ -443,9 +441,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 		retval =
 		    ks7010_sdio_write(priv, READ_STATUS, &read_status,
 				      sizeof(read_status));
-		if (retval) {
+		if (retval)
 			DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
-		}
+
 		goto error_out;
 	}
 
@@ -459,9 +457,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
 	retval =
 	    ks7010_sdio_write(priv, READ_STATUS, &read_status,
 			      sizeof(read_status));
-	if (retval) {
+	if (retval)
 		DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
-	}
+
 	DPRINTK(4, "READ_STATUS=%02X\n", read_status);
 
 	if (atomic_read(&priv->psstatus.confirm_wait)) {
@@ -545,9 +543,9 @@ static void ks7010_rw_function(struct work_struct *work)
 		ks_wlan_hw_rx((void *)priv,
 			      (uint16_t) (((rw_data & RSIZE_MASK) << 4)));
 	}
-	if ((rw_data & WSTATUS_MASK)) {
+	if ((rw_data & WSTATUS_MASK))
 		tx_device_task((void *)priv);
-	}
+
 	_ks_wlan_hw_power_save(priv);
 
  err_out:
@@ -884,9 +882,9 @@ static void ks7010_card_init(struct ks_wlan_private *priv)
 		DPRINTK(1, "wait time out!! SME_START\n");
 	}
 
-	if (priv->mac_address_valid && priv->version_size) {
+	if (priv->mac_address_valid && priv->version_size)
 		priv->dev_state = DEVICE_STATE_PREINIT;
-	}
+
 
 	hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM);
 
@@ -1029,9 +1027,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	init_completion(&priv->ks_wlan_hw.ks7010_sdio_wait);
 	priv->ks_wlan_hw.read_buf = NULL;
 	priv->ks_wlan_hw.read_buf = kmalloc(RX_DATA_SIZE, GFP_KERNEL);
-	if (!priv->ks_wlan_hw.read_buf) {
+	if (!priv->ks_wlan_hw.read_buf)
 		goto error_free_netdev;
-	}
+
 	priv->dev_state = DEVICE_STATE_PREBOOT;
 	priv->net_dev = netdev;
 	priv->firmware_version[0] = '\0';
@@ -1067,9 +1065,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	sdio_claim_host(func);
 	ret = ks7010_sdio_write(priv, INT_PENDING, &rw_data, sizeof(rw_data));
 	sdio_release_host(func);
-	if (ret) {
+	if (ret)
 		DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
-	}
+
 	DPRINTK(4, " clear Interrupt : INT_PENDING=%02X\n", rw_data);
 
 	/* enable ks7010sdio interrupt (INT_GCR_B|INT_READ_STATUS|INT_WRITE_STATUS) */
@@ -1077,9 +1075,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
 	sdio_claim_host(func);
 	ret = ks7010_sdio_write(priv, INT_ENABLE, &rw_data, sizeof(rw_data));
 	sdio_release_host(func);
-	if (ret) {
+	if (ret)
 		DPRINTK(1, " error : INT_ENABLE=%02X\n", rw_data);
-	}
+
 	DPRINTK(4, " enable Interrupt : INT_ENABLE=%02X\n", rw_data);
 	priv->dev_state = DEVICE_STATE_BOOT;
 
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v3 2/6] staging: ks7010: Remove braces following single statement blocks

[Julia Lawall]

On Sun, 18 Sep 2016, sayli karnik wrote:

> The patch removes braces {} for single statement blocks, as suggested by
> checkpatch.pl.

Why do you add blank lines everywhere?

julia

> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 38 +++++++++++++++++-------------------
>  1 file changed, 18 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b993804..8e1f68a 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -157,9 +157,9 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv)
>  		rw_data = WAKEUP_REQ;
>  		retval =
>  		    ks7010_sdio_write(priv, WAKEUP, &rw_data, sizeof(rw_data));
> -		if (retval) {
> +		if (retval)
>  			DPRINTK(1, " error : WAKEUP=%02X\n", rw_data);
> -		}
> +
>  		DPRINTK(4, "wake up : WAKEUP=%02X\n", rw_data);
>  		priv->last_wakeup = jiffies;
>  		++priv->wakeup_count;
> @@ -398,9 +398,8 @@ static void rx_event_task(unsigned long dev)
>  		hostif_receive(priv, rp->data, rp->size);
>  		inc_rxqhead(priv);
>
> -		if (cnt_rxqbody(priv) > 0) {
> +		if (cnt_rxqbody(priv) > 0)
>  			tasklet_schedule(&priv->ks_wlan_hw.rx_bh_task);
> -		}
>  	}
>  }
>
> @@ -426,9 +425,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
>  	retval =
>  	    ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
>  			     hif_align_size(size));
> -	if (retval) {
> +	if (retval)
>  		goto error_out;
> -	}
>
>  	/* length check */
>  	if (size > 2046 || size == 0) {
> @@ -443,9 +441,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
>  		retval =
>  		    ks7010_sdio_write(priv, READ_STATUS, &read_status,
>  				      sizeof(read_status));
> -		if (retval) {
> +		if (retval)
>  			DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
> -		}
> +
>  		goto error_out;
>  	}
>
> @@ -459,9 +457,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
>  	retval =
>  	    ks7010_sdio_write(priv, READ_STATUS, &read_status,
>  			      sizeof(read_status));
> -	if (retval) {
> +	if (retval)
>  		DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
> -	}
> +
>  	DPRINTK(4, "READ_STATUS=%02X\n", read_status);
>
>  	if (atomic_read(&priv->psstatus.confirm_wait)) {
> @@ -545,9 +543,9 @@ static void ks7010_rw_function(struct work_struct *work)
>  		ks_wlan_hw_rx((void *)priv,
>  			      (uint16_t) (((rw_data & RSIZE_MASK) << 4)));
>  	}
> -	if ((rw_data & WSTATUS_MASK)) {
> +	if ((rw_data & WSTATUS_MASK))
>  		tx_device_task((void *)priv);
> -	}
> +
>  	_ks_wlan_hw_power_save(priv);
>
>   err_out:
> @@ -884,9 +882,9 @@ static void ks7010_card_init(struct ks_wlan_private *priv)
>  		DPRINTK(1, "wait time out!! SME_START\n");
>  	}
>
> -	if (priv->mac_address_valid && priv->version_size) {
> +	if (priv->mac_address_valid && priv->version_size)
>  		priv->dev_state = DEVICE_STATE_PREINIT;
> -	}
> +
>
>  	hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM);
>
> @@ -1029,9 +1027,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>  	init_completion(&priv->ks_wlan_hw.ks7010_sdio_wait);
>  	priv->ks_wlan_hw.read_buf = NULL;
>  	priv->ks_wlan_hw.read_buf = kmalloc(RX_DATA_SIZE, GFP_KERNEL);
> -	if (!priv->ks_wlan_hw.read_buf) {
> +	if (!priv->ks_wlan_hw.read_buf)
>  		goto error_free_netdev;
> -	}
> +
>  	priv->dev_state = DEVICE_STATE_PREBOOT;
>  	priv->net_dev = netdev;
>  	priv->firmware_version[0] = '\0';
> @@ -1067,9 +1065,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>  	sdio_claim_host(func);
>  	ret = ks7010_sdio_write(priv, INT_PENDING, &rw_data, sizeof(rw_data));
>  	sdio_release_host(func);
> -	if (ret) {
> +	if (ret)
>  		DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
> -	}
> +
>  	DPRINTK(4, " clear Interrupt : INT_PENDING=%02X\n", rw_data);
>
>  	/* enable ks7010sdio interrupt (INT_GCR_B|INT_READ_STATUS|INT_WRITE_STATUS) */
> @@ -1077,9 +1075,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>  	sdio_claim_host(func);
>  	ret = ks7010_sdio_write(priv, INT_ENABLE, &rw_data, sizeof(rw_data));
>  	sdio_release_host(func);
> -	if (ret) {
> +	if (ret)
>  		DPRINTK(1, " error : INT_ENABLE=%02X\n", rw_data);
> -	}
> +
>  	DPRINTK(4, " enable Interrupt : INT_ENABLE=%02X\n", rw_data);
>  	priv->dev_state = DEVICE_STATE_BOOT;
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/38a21c2a1b3bc3476860cfe2080ef85816569e7f.1474032241.git.karniksayli1995%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 2/6] staging: ks7010: Remove braces following single statement blocks

[sayli karnik]

On Sun, Sep 18, 2016 at 4:32 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Sun, 18 Sep 2016, sayli karnik wrote:
>
>> The patch removes braces {} for single statement blocks, as suggested by
>> checkpatch.pl.
>
> Why do you add blank lines everywhere?
>
I thought it was better that way, even checkpatch.pl did not complain.
Should I amend it?

thanks
sayli

> julia
>
>> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
>> ---
>>  drivers/staging/ks7010/ks7010_sdio.c | 38 +++++++++++++++++-------------------
>>  1 file changed, 18 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
>> index b993804..8e1f68a 100644
>> --- a/drivers/staging/ks7010/ks7010_sdio.c
>> +++ b/drivers/staging/ks7010/ks7010_sdio.c
>> @@ -157,9 +157,9 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv)
>>               rw_data = WAKEUP_REQ;
>>               retval =
>>                   ks7010_sdio_write(priv, WAKEUP, &rw_data, sizeof(rw_data));
>> -             if (retval) {
>> +             if (retval)
>>                       DPRINTK(1, " error : WAKEUP=%02X\n", rw_data);
>> -             }
>> +
>>               DPRINTK(4, "wake up : WAKEUP=%02X\n", rw_data);
>>               priv->last_wakeup = jiffies;
>>               ++priv->wakeup_count;
>> @@ -398,9 +398,8 @@ static void rx_event_task(unsigned long dev)
>>               hostif_receive(priv, rp->data, rp->size);
>>               inc_rxqhead(priv);
>>
>> -             if (cnt_rxqbody(priv) > 0) {
>> +             if (cnt_rxqbody(priv) > 0)
>>                       tasklet_schedule(&priv->ks_wlan_hw.rx_bh_task);
>> -             }
>>       }
>>  }
>>
>> @@ -426,9 +425,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
>>       retval =
>>           ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
>>                            hif_align_size(size));
>> -     if (retval) {
>> +     if (retval)
>>               goto error_out;
>> -     }
>>
>>       /* length check */
>>       if (size > 2046 || size == 0) {
>> @@ -443,9 +441,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
>>               retval =
>>                   ks7010_sdio_write(priv, READ_STATUS, &read_status,
>>                                     sizeof(read_status));
>> -             if (retval) {
>> +             if (retval)
>>                       DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
>> -             }
>> +
>>               goto error_out;
>>       }
>>
>> @@ -459,9 +457,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
>>       retval =
>>           ks7010_sdio_write(priv, READ_STATUS, &read_status,
>>                             sizeof(read_status));
>> -     if (retval) {
>> +     if (retval)
>>               DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
>> -     }
>> +
>>       DPRINTK(4, "READ_STATUS=%02X\n", read_status);
>>
>>       if (atomic_read(&priv->psstatus.confirm_wait)) {
>> @@ -545,9 +543,9 @@ static void ks7010_rw_function(struct work_struct *work)
>>               ks_wlan_hw_rx((void *)priv,
>>                             (uint16_t) (((rw_data & RSIZE_MASK) << 4)));
>>       }
>> -     if ((rw_data & WSTATUS_MASK)) {
>> +     if ((rw_data & WSTATUS_MASK))
>>               tx_device_task((void *)priv);
>> -     }
>> +
>>       _ks_wlan_hw_power_save(priv);
>>
>>   err_out:
>> @@ -884,9 +882,9 @@ static void ks7010_card_init(struct ks_wlan_private *priv)
>>               DPRINTK(1, "wait time out!! SME_START\n");
>>       }
>>
>> -     if (priv->mac_address_valid && priv->version_size) {
>> +     if (priv->mac_address_valid && priv->version_size)
>>               priv->dev_state = DEVICE_STATE_PREINIT;
>> -     }
>> +
>>
>>       hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM);
>>
>> @@ -1029,9 +1027,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>>       init_completion(&priv->ks_wlan_hw.ks7010_sdio_wait);
>>       priv->ks_wlan_hw.read_buf = NULL;
>>       priv->ks_wlan_hw.read_buf = kmalloc(RX_DATA_SIZE, GFP_KERNEL);
>> -     if (!priv->ks_wlan_hw.read_buf) {
>> +     if (!priv->ks_wlan_hw.read_buf)
>>               goto error_free_netdev;
>> -     }
>> +
>>       priv->dev_state = DEVICE_STATE_PREBOOT;
>>       priv->net_dev = netdev;
>>       priv->firmware_version[0] = '\0';
>> @@ -1067,9 +1065,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>>       sdio_claim_host(func);
>>       ret = ks7010_sdio_write(priv, INT_PENDING, &rw_data, sizeof(rw_data));
>>       sdio_release_host(func);
>> -     if (ret) {
>> +     if (ret)
>>               DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
>> -     }
>> +
>>       DPRINTK(4, " clear Interrupt : INT_PENDING=%02X\n", rw_data);
>>
>>       /* enable ks7010sdio interrupt (INT_GCR_B|INT_READ_STATUS|INT_WRITE_STATUS) */
>> @@ -1077,9 +1075,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
>>       sdio_claim_host(func);
>>       ret = ks7010_sdio_write(priv, INT_ENABLE, &rw_data, sizeof(rw_data));
>>       sdio_release_host(func);
>> -     if (ret) {
>> +     if (ret)
>>               DPRINTK(1, " error : INT_ENABLE=%02X\n", rw_data);
>> -     }
>> +
>>       DPRINTK(4, " enable Interrupt : INT_ENABLE=%02X\n", rw_data);
>>       priv->dev_state = DEVICE_STATE_BOOT;
>>
>> --
>> 2.7.4
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/38a21c2a1b3bc3476860cfe2080ef85816569e7f.1474032241.git.karniksayli1995%40gmail.com.
>> For more options, visit https://groups.google.com/d/optout.
>>

Re: [Outreachy kernel] [PATCH v3 2/6] staging: ks7010: Remove braces following single statement blocks

[Julia Lawall]

On Mon, 19 Sep 2016, sayli karnik wrote:

> On Sun, Sep 18, 2016 at 4:32 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Sun, 18 Sep 2016, sayli karnik wrote:
> >
> >> The patch removes braces {} for single statement blocks, as suggested by
> >> checkpatch.pl.
> >
> > Why do you add blank lines everywhere?
> >
> I thought it was better that way, even checkpatch.pl did not complain.
> Should I amend it?

I guess blank lines are a matter of taste, and if you think it looks
better then no problem :)

julia

>
> thanks
> sayli
>
> > julia
> >
> >> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> >> ---
> >>  drivers/staging/ks7010/ks7010_sdio.c | 38 +++++++++++++++++-------------------
> >>  1 file changed, 18 insertions(+), 20 deletions(-)
> >>
> >> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> >> index b993804..8e1f68a 100644
> >> --- a/drivers/staging/ks7010/ks7010_sdio.c
> >> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> >> @@ -157,9 +157,9 @@ void ks_wlan_hw_wakeup_request(struct ks_wlan_private *priv)
> >>               rw_data = WAKEUP_REQ;
> >>               retval =
> >>                   ks7010_sdio_write(priv, WAKEUP, &rw_data, sizeof(rw_data));
> >> -             if (retval) {
> >> +             if (retval)
> >>                       DPRINTK(1, " error : WAKEUP=%02X\n", rw_data);
> >> -             }
> >> +
> >>               DPRINTK(4, "wake up : WAKEUP=%02X\n", rw_data);
> >>               priv->last_wakeup = jiffies;
> >>               ++priv->wakeup_count;
> >> @@ -398,9 +398,8 @@ static void rx_event_task(unsigned long dev)
> >>               hostif_receive(priv, rp->data, rp->size);
> >>               inc_rxqhead(priv);
> >>
> >> -             if (cnt_rxqbody(priv) > 0) {
> >> +             if (cnt_rxqbody(priv) > 0)
> >>                       tasklet_schedule(&priv->ks_wlan_hw.rx_bh_task);
> >> -             }
> >>       }
> >>  }
> >>
> >> @@ -426,9 +425,8 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
> >>       retval =
> >>           ks7010_sdio_read(priv, DATA_WINDOW, &rx_buffer->data[0],
> >>                            hif_align_size(size));
> >> -     if (retval) {
> >> +     if (retval)
> >>               goto error_out;
> >> -     }
> >>
> >>       /* length check */
> >>       if (size > 2046 || size == 0) {
> >> @@ -443,9 +441,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
> >>               retval =
> >>                   ks7010_sdio_write(priv, READ_STATUS, &read_status,
> >>                                     sizeof(read_status));
> >> -             if (retval) {
> >> +             if (retval)
> >>                       DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
> >> -             }
> >> +
> >>               goto error_out;
> >>       }
> >>
> >> @@ -459,9 +457,9 @@ static void ks_wlan_hw_rx(void *dev, uint16_t size)
> >>       retval =
> >>           ks7010_sdio_write(priv, READ_STATUS, &read_status,
> >>                             sizeof(read_status));
> >> -     if (retval) {
> >> +     if (retval)
> >>               DPRINTK(1, " error : READ_STATUS=%02X\n", read_status);
> >> -     }
> >> +
> >>       DPRINTK(4, "READ_STATUS=%02X\n", read_status);
> >>
> >>       if (atomic_read(&priv->psstatus.confirm_wait)) {
> >> @@ -545,9 +543,9 @@ static void ks7010_rw_function(struct work_struct *work)
> >>               ks_wlan_hw_rx((void *)priv,
> >>                             (uint16_t) (((rw_data & RSIZE_MASK) << 4)));
> >>       }
> >> -     if ((rw_data & WSTATUS_MASK)) {
> >> +     if ((rw_data & WSTATUS_MASK))
> >>               tx_device_task((void *)priv);
> >> -     }
> >> +
> >>       _ks_wlan_hw_power_save(priv);
> >>
> >>   err_out:
> >> @@ -884,9 +882,9 @@ static void ks7010_card_init(struct ks_wlan_private *priv)
> >>               DPRINTK(1, "wait time out!! SME_START\n");
> >>       }
> >>
> >> -     if (priv->mac_address_valid && priv->version_size) {
> >> +     if (priv->mac_address_valid && priv->version_size)
> >>               priv->dev_state = DEVICE_STATE_PREINIT;
> >> -     }
> >> +
> >>
> >>       hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM);
> >>
> >> @@ -1029,9 +1027,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> >>       init_completion(&priv->ks_wlan_hw.ks7010_sdio_wait);
> >>       priv->ks_wlan_hw.read_buf = NULL;
> >>       priv->ks_wlan_hw.read_buf = kmalloc(RX_DATA_SIZE, GFP_KERNEL);
> >> -     if (!priv->ks_wlan_hw.read_buf) {
> >> +     if (!priv->ks_wlan_hw.read_buf)
> >>               goto error_free_netdev;
> >> -     }
> >> +
> >>       priv->dev_state = DEVICE_STATE_PREBOOT;
> >>       priv->net_dev = netdev;
> >>       priv->firmware_version[0] = '\0';
> >> @@ -1067,9 +1065,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> >>       sdio_claim_host(func);
> >>       ret = ks7010_sdio_write(priv, INT_PENDING, &rw_data, sizeof(rw_data));
> >>       sdio_release_host(func);
> >> -     if (ret) {
> >> +     if (ret)
> >>               DPRINTK(1, " error : INT_PENDING=%02X\n", rw_data);
> >> -     }
> >> +
> >>       DPRINTK(4, " clear Interrupt : INT_PENDING=%02X\n", rw_data);
> >>
> >>       /* enable ks7010sdio interrupt (INT_GCR_B|INT_READ_STATUS|INT_WRITE_STATUS) */
> >> @@ -1077,9 +1075,9 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> >>       sdio_claim_host(func);
> >>       ret = ks7010_sdio_write(priv, INT_ENABLE, &rw_data, sizeof(rw_data));
> >>       sdio_release_host(func);
> >> -     if (ret) {
> >> +     if (ret)
> >>               DPRINTK(1, " error : INT_ENABLE=%02X\n", rw_data);
> >> -     }
> >> +
> >>       DPRINTK(4, " enable Interrupt : INT_ENABLE=%02X\n", rw_data);
> >>       priv->dev_state = DEVICE_STATE_BOOT;
> >>
> >> --
> >> 2.7.4
> >>
> >> --
> >> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/38a21c2a1b3bc3476860cfe2080ef85816569e7f.1474032241.git.karniksayli1995%40gmail.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >>
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAKG5xWizCzdeFj4cLg1Ghs%3D90uu-8XK1Rvnam5qMxQr7L9PfaA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

[PATCH v2 3/6] staging: ks7010: Remove space after '(' and before ')'

[sayli karnik]

The patch fixes the following errors detected by checkpatch.pl:
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that open parenthesis '('

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 8e1f68a..b0c6f93 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -35,18 +35,18 @@ MODULE_DEVICE_TABLE(sdio, ks7010_sdio_ids);
 /* macro */
 
 #define inc_txqhead(priv) \
-        ( priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE )
+        (priv->tx_dev.qhead = (priv->tx_dev.qhead + 1) % TX_DEVICE_BUFF_SIZE)
 #define inc_txqtail(priv) \
-        ( priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE )
+        (priv->tx_dev.qtail = (priv->tx_dev.qtail + 1) % TX_DEVICE_BUFF_SIZE)
 #define cnt_txqbody(priv) \
-        (((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE )
+        (((priv->tx_dev.qtail + TX_DEVICE_BUFF_SIZE) - (priv->tx_dev.qhead)) % TX_DEVICE_BUFF_SIZE)
 
 #define inc_rxqhead(priv) \
-        ( priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE )
+        (priv->rx_dev.qhead = (priv->rx_dev.qhead + 1) % RX_DEVICE_BUFF_SIZE)
 #define inc_rxqtail(priv) \
-        ( priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE )
+        (priv->rx_dev.qtail = (priv->rx_dev.qtail + 1) % RX_DEVICE_BUFF_SIZE)
 #define cnt_rxqbody(priv) \
-        (((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE )
+        (((priv->rx_dev.qtail + RX_DEVICE_BUFF_SIZE) - (priv->rx_dev.qhead)) % RX_DEVICE_BUFF_SIZE)
 
 static int ks7010_sdio_read(struct ks_wlan_private *priv, unsigned int address,
 			    unsigned char *buffer, int length)
-- 
2.7.4

[PATCH v2 4/6] staging: ks7010: Remove unnecessary blank lines

[sayli karnik]

The patch removes unnecessary blank lines as detected by checkpatch.pl.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
v2: Code under comments removed as suggested by Julia.

 drivers/staging/ks7010/ks7010_sdio.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index b0c6f93..bee7504 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -180,8 +180,6 @@ int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 
 	if (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
 	    (priv->connect_status & CONNECT_STATUS_MASK) == CONNECT_STATUS) {
-
-		//DPRINTK(1,"psstatus.status=%d\n",atomic_read(&priv->psstatus.status));
 		if (priv->dev_state == DEVICE_STATE_SLEEP) {
 			switch (atomic_read(&priv->psstatus.status)) {
 			case PS_SNOOZE:	/* 4 */
@@ -244,7 +242,6 @@ int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
 				break;
 			}
 		}
-
 	}
 
 	return rc;
@@ -343,7 +340,6 @@ static void tx_device_task(void *dev)
 						   &priv->ks_wlan_hw.rw_wq, 1);
 				return;
 			}
-
 		}
 		kfree(sp->sendp);	/* allocated memory free */
 		if (sp->complete_handler)	/* TX Complete */
@@ -597,7 +593,6 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 				}
 				complete(&priv->psstatus.wakeup_wait);
 			}
-
 		}
 
 		do {
-- 
2.7.4

Re: [PATCH v2 4/6] staging: ks7010: Remove unnecessary blank lines

[Greg KH]

On Fri, Sep 16, 2016 at 07:20:37PM +0530, sayli karnik wrote:
> The patch removes unnecessary blank lines as detected by checkpatch.pl.
> 
> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
> ---
> v2: Code under comments removed as suggested by Julia.
> 
>  drivers/staging/ks7010/ks7010_sdio.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b0c6f93..bee7504 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -180,8 +180,6 @@ int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
>  
>  	if (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
>  	    (priv->connect_status & CONNECT_STATUS_MASK) == CONNECT_STATUS) {
> -
> -		//DPRINTK(1,"psstatus.status=%d\n",atomic_read(&priv->psstatus.status));

That is not a "unnecessary blank line" :(

Please update your changelog text when you do something else in the
patch...

thanks,

greg k-h

Re: [PATCH v2 4/6] staging: ks7010: Remove unnecessary blank lines

[sayli karnik]

On Fri, Sep 16, 2016 at 7:35 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Sep 16, 2016 at 07:20:37PM +0530, sayli karnik wrote:
>> The patch removes unnecessary blank lines as detected by checkpatch.pl.
>>
>> Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
>> ---
>> v2: Code under comments removed as suggested by Julia.
>>
>>  drivers/staging/ks7010/ks7010_sdio.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
>> index b0c6f93..bee7504 100644
>> --- a/drivers/staging/ks7010/ks7010_sdio.c
>> +++ b/drivers/staging/ks7010/ks7010_sdio.c
>> @@ -180,8 +180,6 @@ int _ks_wlan_hw_power_save(struct ks_wlan_private *priv)
>>
>>       if (priv->reg.operation_mode == MODE_INFRASTRUCTURE &&
>>           (priv->connect_status & CONNECT_STATUS_MASK) == CONNECT_STATUS) {
>> -
>> -             //DPRINTK(1,"psstatus.status=%d\n",atomic_read(&priv->psstatus.status));
>
> That is not a "unnecessary blank line" :(
>
> Please update your changelog text when you do something else in the
> patch...
>
> thanks,
>
> greg k-h

Yes I'll update the changelog and send a v3.

thanks,

sayli

[PATCH v2 5/6] staging: ks7010: Remove the space after a type cast

[sayli karnik]

The patch removes an unnecessary space after a cast, as detected by
checkpatch.pl.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index bee7504..489291b 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -537,7 +537,7 @@ static void ks7010_rw_function(struct work_struct *work)
 
 	if (rw_data & RSIZE_MASK) {	/* Read schedule */
 		ks_wlan_hw_rx((void *)priv,
-			      (uint16_t) (((rw_data & RSIZE_MASK) << 4)));
+			      (uint16_t)(((rw_data & RSIZE_MASK) << 4)));
 	}
 	if ((rw_data & WSTATUS_MASK))
 		tx_device_task((void *)priv);
@@ -609,7 +609,7 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 			rsize = rw_data & RSIZE_MASK;
 			if (rsize) {	/* Read schedule */
 				ks_wlan_hw_rx((void *)priv,
-					      (uint16_t) (((rsize) << 4)));
+					      (uint16_t)(((rsize) << 4)));
 			}
 			if (rw_data & WSTATUS_MASK) {
 #if 0
@@ -1150,7 +1150,7 @@ static void ks7010_sdio_remove(struct sdio_func *func)
 			    cpu_to_le16((uint16_t)
 					(sizeof(*pp) -
 					 sizeof(pp->header.size)));
-			pp->header.event = cpu_to_le16((uint16_t) HIF_STOP_REQ);
+			pp->header.event = cpu_to_le16((uint16_t)HIF_STOP_REQ);
 
 			sdio_claim_host(func);
 			write_to_device(priv, (unsigned char *)pp,
-- 
2.7.4

[PATCH v2 6/6] staging: ks7010: Remove extra round braces around expressions/variables

[sayli karnik]

This patch removes excess round braces around expressions/variables.

Signed-off-by: sayli karnik <karniksayli1995@gmail.com>
---
 drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 489291b..767b04b 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -537,7 +537,7 @@ static void ks7010_rw_function(struct work_struct *work)
 
 	if (rw_data & RSIZE_MASK) {	/* Read schedule */
 		ks_wlan_hw_rx((void *)priv,
-			      (uint16_t)(((rw_data & RSIZE_MASK) << 4)));
+			      (uint16_t)((rw_data & RSIZE_MASK) << 4));
 	}
 	if ((rw_data & WSTATUS_MASK))
 		tx_device_task((void *)priv);
@@ -609,7 +609,7 @@ static void ks_sdio_interrupt(struct sdio_func *func)
 			rsize = rw_data & RSIZE_MASK;
 			if (rsize) {	/* Read schedule */
 				ks_wlan_hw_rx((void *)priv,
-					      (uint16_t)(((rsize) << 4)));
+					      (uint16_t)(rsize << 4));
 			}
 			if (rw_data & WSTATUS_MASK) {
 #if 0
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v3 0/6] staging: ks7010: Fix multiple checkpatch warnings

[Greg KH]

On Sun, Sep 18, 2016 at 11:05:23AM +0530, sayli karnik wrote:
> This patchset fixes several checkpatch issues detected in the ks7010_sdio.c
> file of the ks7010 driver. 

You only sent 1 patch in this series :(

Please send all 6.

thanks,

greg k-h