All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Matthias Kaehlcke <mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Douglas Anderson
	<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 4/4] regulator: Prevent falling too fast
Date: Fri, 16 Sep 2016 17:32:53 +0100	[thread overview]
Message-ID: <20160916163253.GA10189@sirena.org.uk> (raw)
In-Reply-To: <20160915180223.GE62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote:
> El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit:

> > The obvious question here is how the OVP hardware knows about the new
> > voltage and why we're bodging this in the regulator core rather than in
> > the OVP hardware.

> The OVP hardware is part of the regulator and the regulator is not
> notified directly about voltage changes. The regulator transforms the
> PWM input into DC output and does the OVP internally with the limits
> described above.

So the PWM is just configuring this external regulator chip (which
doesn't seem to be described in DT...) and that's just incredibly bad at
coping with voltage changes?  It does sound rather like we ought to be
representing this chip directly in case it needs other workarounds.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: lgirdwood@gmail.com, Douglas Anderson <dianders@chromium.org>,
	briannorris@chromium.org, javier@dowhile0.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 4/4] regulator: Prevent falling too fast
Date: Fri, 16 Sep 2016 17:32:53 +0100	[thread overview]
Message-ID: <20160916163253.GA10189@sirena.org.uk> (raw)
In-Reply-To: <20160915180223.GE62872@google.com>

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote:
> El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit:

> > The obvious question here is how the OVP hardware knows about the new
> > voltage and why we're bodging this in the regulator core rather than in
> > the OVP hardware.

> The OVP hardware is part of the regulator and the regulator is not
> notified directly about voltage changes. The regulator transforms the
> PWM input into DC output and does the OVP internally with the limits
> described above.

So the PWM is just configuring this external regulator chip (which
doesn't seem to be described in DT...) and that's just incredibly bad at
coping with voltage changes?  It does sound rather like we ought to be
representing this chip directly in case it needs other workarounds.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  parent reply	other threads:[~2016-09-16 16:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 19:05 [PATCH v4 4/4] regulator: Prevent falling too fast Matthias Kaehlcke
2016-09-06 19:05 ` Matthias Kaehlcke
     [not found] ` <20160906190524.GB79728-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-12 18:56   ` Mark Brown
2016-09-12 18:56     ` Mark Brown
     [not found]     ` <20160912185633.GH27946-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-13 17:21       ` Matthias Kaehlcke
2016-09-13 17:21         ` Matthias Kaehlcke
     [not found]         ` <20160913172140.GC62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-15 14:39           ` Mark Brown
2016-09-15 14:39             ` Mark Brown
     [not found]             ` <20160915143945.GJ27974-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-15 18:02               ` Matthias Kaehlcke
2016-09-15 18:02                 ` Matthias Kaehlcke
     [not found]                 ` <20160915180223.GE62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-16 16:32                   ` Mark Brown [this message]
2016-09-16 16:32                     ` Mark Brown
     [not found]                     ` <20160916163253.GA10189-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-16 18:31                       ` Matthias Kaehlcke
2016-09-16 18:31                         ` Matthias Kaehlcke
     [not found]                         ` <20160916183145.GF62872-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-16 18:48                           ` Mark Brown
2016-09-16 18:48                             ` Mark Brown
2016-09-19 18:39                     ` Doug Anderson
2016-09-24 18:41                       ` Mark Brown
     [not found]                         ` <20160924184133.seh6v6eayt7hwgue-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-26 17:41                           ` Doug Anderson
2016-09-26 17:41                             ` Doug Anderson
2016-10-28 18:15                             ` Mark Brown
     [not found]                               ` <20161028181521.ywzmow6bgndfotq3-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-12-12 21:15                                 ` Matthias Kaehlcke
2016-12-12 21:15                                   ` Matthias Kaehlcke
     [not found]                                   ` <20161212211502.GA96889-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-13 17:19                                     ` Mark Brown
2016-12-13 17:19                                       ` Mark Brown
2016-12-13 20:00                                       ` Doug Anderson
2016-12-13 23:14                                         ` Matthias Kaehlcke
     [not found]                                         ` <CAD=FV=WhUVeq5GZ5-ae4SxypHGB9jWqgvkO02S=G6Zz6cexRzQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-14 13:21                                           ` Mark Brown
2016-12-14 13:21                                             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160916163253.GA10189@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.