[PATCH] Staging: i4l: Remove NULL comparison.

[PATCH] Staging: i4l: Remove NULL comparison.

[Sandhya Bankar]

Remove NULL comparison with ! operator.
This patch removes the explicit NULL comparison.
This issue was found by checkpatch.pl script.


Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/i4l/act2000/act2000_isa.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
index c800da8..808bb3b 100755
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -166,7 +166,7 @@ act2000_isa_config_port(act2000_card *card, unsigned short portbase)
 		release_region(card->port, ISA_REGION);
 		card->flags &= ~ACT2000_FLAGS_PVALID;
 	}
-	if (request_region(portbase, ACT2000_PORTLEN, card->regname) == NULL)
+	if (!request_region(portbase, ACT2000_PORTLEN, card->regname))
 		return -EBUSY;
 	else {
 		card->port = portbase;
@@ -244,7 +244,7 @@ act2000_isa_receive(act2000_card *card)
 				if (valid) {
 					card->idat.isa.rcvlen = ((actcapi_msghdr *)&card->idat.isa.rcvhdr)->len;
 					card->idat.isa.rcvskb = dev_alloc_skb(card->idat.isa.rcvlen);
-					if (card->idat.isa.rcvskb == NULL) {
+					if (!card->idat.isa.rcvskb) {
 						card->idat.isa.rcvignore = 1;
 						printk(KERN_WARNING
 						       "act2000_isa_receive: no memory\n");
-- 
1.7.1

Re: [Outreachy kernel] [PATCH] Staging: i4l: Remove NULL comparison.

[Julia Lawall]

On Sat, 17 Sep 2016, Sandhya Bankar wrote:

> Remove NULL comparison with ! operator.
> This patch removes the explicit NULL comparison.

The first two sentences seem to say the same thing?  Actually, the first
one is ambiguous.  It looks like NULL is being compared to !.

julia

> This issue was found by checkpatch.pl script.
>
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
> index c800da8..808bb3b 100755
> --- a/drivers/staging/i4l/act2000/act2000_isa.c
> +++ b/drivers/staging/i4l/act2000/act2000_isa.c
> @@ -166,7 +166,7 @@ act2000_isa_config_port(act2000_card *card, unsigned short portbase)
>  		release_region(card->port, ISA_REGION);
>  		card->flags &= ~ACT2000_FLAGS_PVALID;
>  	}
> -	if (request_region(portbase, ACT2000_PORTLEN, card->regname) == NULL)
> +	if (!request_region(portbase, ACT2000_PORTLEN, card->regname))
>  		return -EBUSY;
>  	else {
>  		card->port = portbase;
> @@ -244,7 +244,7 @@ act2000_isa_receive(act2000_card *card)
>  				if (valid) {
>  					card->idat.isa.rcvlen = ((actcapi_msghdr *)&card->idat.isa.rcvhdr)->len;
>  					card->idat.isa.rcvskb = dev_alloc_skb(card->idat.isa.rcvlen);
> -					if (card->idat.isa.rcvskb == NULL) {
> +					if (!card->idat.isa.rcvskb) {
>  						card->idat.isa.rcvignore = 1;
>  						printk(KERN_WARNING
>  						       "act2000_isa_receive: no memory\n");
> --
> 1.7.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917002853.GA14373%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>