[PATCH] Staging: i4l: Do not initialise statics to 0.

[PATCH] Staging: i4l: Do not initialise statics to 0.

[Sandhya Bankar]

Do not initialise statics to 0.
static variable by default initialise to 0,so
no need to explicite initialisation.
This issue was found by checkpatch .

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/staging/i4l/act2000/module.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
index 68073d0..39a8940 100755
--- a/drivers/staging/i4l/act2000/module.c
+++ b/drivers/staging/i4l/act2000/module.c
@@ -28,7 +28,7 @@ static unsigned short act2000_isa_ports[] =
 static act2000_card *cards = (act2000_card *) NULL;
 
 /* Parameters to be set by insmod */
-static int   act_bus  =  0;
+static int   act_bus;
 static int   act_port = -1;  /* -1 = Autoprobe  */
 static int   act_irq  = -1;
 static char *act_id   = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
-- 
1.7.1

Re: [Outreachy kernel] [PATCH] Staging: i4l: Do not initialise statics to 0.

[Julia Lawall]

On Sat, 17 Sep 2016, Sandhya Bankar wrote:

> Do not initialise statics to 0.
> static variable by default initialise to 0,so
> no need to explicite initialisation.
> This issue was found by checkpatch .

Your commit message should fill more of the available 80 characters.
Sentences should start with a capital letter.  Punctuation should have no
space before and a space after.  The commit message is preserved forever,
so it is good for it to look nice.

julia

>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
>  drivers/staging/i4l/act2000/module.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 68073d0..39a8940 100755
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -28,7 +28,7 @@ static unsigned short act2000_isa_ports[] =
>  static act2000_card *cards = (act2000_card *) NULL;
>
>  /* Parameters to be set by insmod */
> -static int   act_bus  =  0;
> +static int   act_bus;
>  static int   act_port = -1;  /* -1 = Autoprobe  */
>  static int   act_irq  = -1;
>  static char *act_id   = "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0";
> --
> 1.7.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917011052.GA14721%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>