From: Florian Westphal <fw@strlen.de>
To: Gao Feng <fgao@ikuai8.com>
Cc: Florian Westphal <fw@strlen.de>,
kernel test robot <xiaolong.ye@intel.com>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>,
lkp@01.org
Subject: Re: [netfilter-core] [lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a
Date: Sat, 17 Sep 2016 12:40:21 +0200 [thread overview]
Message-ID: <20160917104021.GF5204@breakpoint.cc> (raw)
In-Reply-To: <CA+6hz4rLzt+u8P+4rOrc3brp4kNK6DrCk546G-jGvcVPVcDmrg@mail.gmail.com>
Gao Feng <fgao@ikuai8.com> wrote:
[ drop netdev & coreteam from cc list ]
> On Sat, Sep 17, 2016 at 1:18 AM, Florian Westphal <fw@strlen.de> wrote:
>
> > Gao Feng <fgao@ikuai8.com> wrote:
> > > > [ 23.465616] ------------[ cut here ]------------
> > > > [ 23.466477] WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_
> > seqadj.c:232
> > > > nf_ct_seq_offset+0x7a/0x9a
> > > > [ 23.468458] Missing nfct_seqadj_ext_add() setup call
> > > >
> > >
> > > It should be that nf_ct_add_synproxy failed and the seqadj extentision is
> > > not added.
> >
> > Note that nfct_synproxy_ext_add always returns NULL if
> > CONFIG_NETFILTER_SYNPROXY=n
> >
> > The warning should also be removed.
>
>
> When CONFIG_NETFILTER_SYNPROXY=NULL, it will not reach
> nfct_synproxy_ext_add, because nfct_synproxy also returns the NULL.
Right. Apologies, I did not realize this report is about an old
revision of the patch that was never applied to the tree.
So I think we can just ignore this report.
[ its this patch:
https://patchwork.ozlabs.org/patch/665102/ ]
> I am not clear why the commit breaks conntrack when if SYNPROXY=n based on
> my response above.
Its fine, forget about it.
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: lkp@lists.01.org
Subject: Re: [netfilter-core] [lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a
Date: Sat, 17 Sep 2016 12:40:21 +0200 [thread overview]
Message-ID: <20160917104021.GF5204@breakpoint.cc> (raw)
In-Reply-To: <CA+6hz4rLzt+u8P+4rOrc3brp4kNK6DrCk546G-jGvcVPVcDmrg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]
Gao Feng <fgao@ikuai8.com> wrote:
[ drop netdev & coreteam from cc list ]
> On Sat, Sep 17, 2016 at 1:18 AM, Florian Westphal <fw@strlen.de> wrote:
>
> > Gao Feng <fgao@ikuai8.com> wrote:
> > > > [ 23.465616] ------------[ cut here ]------------
> > > > [ 23.466477] WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_
> > seqadj.c:232
> > > > nf_ct_seq_offset+0x7a/0x9a
> > > > [ 23.468458] Missing nfct_seqadj_ext_add() setup call
> > > >
> > >
> > > It should be that nf_ct_add_synproxy failed and the seqadj extentision is
> > > not added.
> >
> > Note that nfct_synproxy_ext_add always returns NULL if
> > CONFIG_NETFILTER_SYNPROXY=n
> >
> > The warning should also be removed.
>
>
> When CONFIG_NETFILTER_SYNPROXY=NULL, it will not reach
> nfct_synproxy_ext_add, because nfct_synproxy also returns the NULL.
Right. Apologies, I did not realize this report is about an old
revision of the patch that was never applied to the tree.
So I think we can just ignore this report.
[ its this patch:
https://patchwork.ozlabs.org/patch/665102/ ]
> I am not clear why the commit breaks conntrack when if SYNPROXY=n based on
> my response above.
Its fine, forget about it.
next prev parent reply other threads:[~2016-09-17 10:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 1:48 [PATCH 1/2 nf] netfilter: seqadj: Fix some possible panics of seqadj when mem is exhausted fgao
2016-09-02 4:50 ` Liping Zhang
2016-09-02 4:57 ` Gao Feng
2016-09-16 14:04 ` [lkp] [netfilter] 68263ddb47: WARNING: CPU: 0 PID: 1225 at net/netfilter/nf_conntrack_seqadj.c:232 nf_ct_seq_offset+0x7a/0x9a kernel test robot
2016-09-16 14:04 ` kernel test robot
[not found] ` <CA+6hz4o_Jub=zUcnXjy=oXS_5uZkxxw2Jv7p2FvdMqHV0pg+hw@mail.gmail.com>
2016-09-16 17:18 ` [netfilter-core] [lkp] " Florian Westphal
2016-09-16 17:18 ` Florian Westphal
[not found] ` <CA+6hz4rLzt+u8P+4rOrc3brp4kNK6DrCk546G-jGvcVPVcDmrg@mail.gmail.com>
2016-09-17 10:40 ` Florian Westphal [this message]
2016-09-17 10:40 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917104021.GF5204@breakpoint.cc \
--to=fw@strlen.de \
--cc=fgao@ikuai8.com \
--cc=lkp@01.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.