Re: [PATCH v2] staging: xgifb: Replace explicit NULL comparison

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Sep 16, 2016 at 04:26:56PM +0530, Namrata A Shettar wrote:
> Replace explicit NULL comparison  with equivalent expression to resolve
> checkpatch issue.
> - x != NULL => x
> 
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  Changes in v2:
>  -sent using plain text mail agent
> 
>  drivers/staging/xgifb/XGI_main_26.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
>   diff --git a/drivers/staging/xgifb/XGI_main_26.c
>   b/drivers/staging/xgifb/XGI_main_26.c
>   index d56ef14..23a3bd7 100644
>   --- a/drivers/staging/xgifb/XGI_main_26.c
>   +++ b/drivers/staging/xgifb/XGI_main_26.c
>   @@ -2085,7 +2085,7 @@ static int __init xgifb_init(void)
>    {
>            char *option = NULL;
> 
> 	   -       if (forcecrt2type != NULL)
> 	   +       if (forcecrt2type)
> 	                   XGIfb_search_crt2type(forcecrt2type);
> 			           if (fb_get_options("xgifb", &option))
> 				                   return -ENODEV;

This is really corrupted, I don't know how you did this, it's a new one
to me...

Please fix up and resend.

thanks,

greg k-h