* [PATCH v2] staging: xgifb: Replace explicit NULL comparison
@ 2016-09-16 10:56 Namrata A Shettar
2016-09-17 18:38 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Namrata A Shettar @ 2016-09-16 10:56 UTC (permalink / raw)
To: outreachy-kernel
Cc: Arnaud Patard, Greg Kroah-Hartman, Clifton Barnes, Geliang Tang,
Ben Marsh, Janani Ravichandran, Benoit Hiller
Replace explicit NULL comparison with equivalent expression to resolve
checkpatch issue.
- x != NULL => x
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
---
Changes in v2:
-sent using plain text mail agent
drivers/staging/xgifb/XGI_main_26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index d56ef14..23a3bd7 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -2085,7 +2085,7 @@ static int __init xgifb_init(void)
{
char *option = NULL;
- if (forcecrt2type != NULL)
+ if (forcecrt2type)
XGIfb_search_crt2type(forcecrt2type);
if (fb_get_options("xgifb", &option))
return -ENODEV;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: xgifb: Replace explicit NULL comparison
2016-09-16 10:56 [PATCH v2] staging: xgifb: Replace explicit NULL comparison Namrata A Shettar
@ 2016-09-17 18:38 ` Greg Kroah-Hartman
2016-09-18 4:48 ` Namrata A Shettar
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2016-09-17 18:38 UTC (permalink / raw)
To: Namrata A Shettar
Cc: outreachy-kernel, Arnaud Patard, Clifton Barnes, Geliang Tang,
Ben Marsh, Janani Ravichandran, Benoit Hiller
On Fri, Sep 16, 2016 at 04:26:56PM +0530, Namrata A Shettar wrote:
> Replace explicit NULL comparison with equivalent expression to resolve
> checkpatch issue.
> - x != NULL => x
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> Changes in v2:
> -sent using plain text mail agent
>
> drivers/staging/xgifb/XGI_main_26.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c
> b/drivers/staging/xgifb/XGI_main_26.c
> index d56ef14..23a3bd7 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -2085,7 +2085,7 @@ static int __init xgifb_init(void)
> {
> char *option = NULL;
>
> - if (forcecrt2type != NULL)
> + if (forcecrt2type)
> XGIfb_search_crt2type(forcecrt2type);
> if (fb_get_options("xgifb", &option))
> return -ENODEV;
This is really corrupted, I don't know how you did this, it's a new one
to me...
Please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: xgifb: Replace explicit NULL comparison
2016-09-17 18:38 ` Greg Kroah-Hartman
@ 2016-09-18 4:48 ` Namrata A Shettar
0 siblings, 0 replies; 3+ messages in thread
From: Namrata A Shettar @ 2016-09-18 4:48 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: outreachy-kernel, Arnaud Patard, Clifton Barnes, Geliang Tang,
Ben Marsh, Janani Ravichandran, Benoit Hiller
On Sat, Sep 17, 2016 at 08:38:46PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Sep 16, 2016 at 04:26:56PM +0530, Namrata A Shettar wrote:
> > Replace explicit NULL comparison with equivalent expression to resolve
> > checkpatch issue.
> > - x != NULL => x
> >
> > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > ---
> > Changes in v2:
> > -sent using plain text mail agent
> >
> > drivers/staging/xgifb/XGI_main_26.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/xgifb/XGI_main_26.c
> > b/drivers/staging/xgifb/XGI_main_26.c
> > index d56ef14..23a3bd7 100644
> > --- a/drivers/staging/xgifb/XGI_main_26.c
> > +++ b/drivers/staging/xgifb/XGI_main_26.c
> > @@ -2085,7 +2085,7 @@ static int __init xgifb_init(void)
> > {
> > char *option = NULL;
> >
> > - if (forcecrt2type != NULL)
> > + if (forcecrt2type)
> > XGIfb_search_crt2type(forcecrt2type);
> > if (fb_get_options("xgifb", &option))
> > return -ENODEV;
>
> This is really corrupted, I don't know how you did this, it's a new one
> to me...
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
Sorry for that :/ Will look that up and resend.
thanks,
namrata
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-18 4:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-16 10:56 [PATCH v2] staging: xgifb: Replace explicit NULL comparison Namrata A Shettar
2016-09-17 18:38 ` Greg Kroah-Hartman
2016-09-18 4:48 ` Namrata A Shettar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.