Re: [Outreachy kernel] [PATCH v2] Staging: i4l: Return NULL instead of 0.

[Alison Schofield <amsfield22@gmail.com>]

On Sat, Sep 17, 2016 at 12:47:02PM +0530, Sandhya Bankar wrote:
> Return NULL instead of 0, if card with given driverId is not found.
> 
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>

Greg, 

I was going to say something else here about there being a lot of
printk's that maybe could be converted, but then I looked at the TODO
file.

>>    * The icn, pcbit and act2000 drivers are dead, remove them in 2017
>>    after another longterm kernel has been released, just in the
>>    unlikely case someone still has this hardware.

Do you want work done on a driver that's on it's way out?

alisons


> ---
> Changes in v2:
> * Correcting commit message
>  drivers/staging/i4l/act2000/module.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c
> index 39a8940..6a6c911 100755
> --- a/drivers/staging/i4l/act2000/module.c
> +++ b/drivers/staging/i4l/act2000/module.c
> @@ -499,7 +499,7 @@ act2000_findcard(int driverid)
>  			return p;
>  		p = p->next;
>  	}
> -	return (act2000_card *) 0;
> +	return NULL;
>  }
>  
>  /*
> -- 
> 1.7.1
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160917071702.GA16260%40sandhya.
> For more options, visit https://groups.google.com/d/optout.