From: Greg KH <gregkh@linuxfoundation.org>
To: Alison Schofield <amsfield22@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: i4l: Return NULL instead of 0.
Date: Sat, 17 Sep 2016 23:36:23 +0200 [thread overview]
Message-ID: <20160917213623.GB31410@kroah.com> (raw)
In-Reply-To: <20160917212443.GC2854@d830.WORKGROUP>
On Sat, Sep 17, 2016 at 02:24:45PM -0700, Alison Schofield wrote:
> On Sat, Sep 17, 2016 at 12:47:02PM +0530, Sandhya Bankar wrote:
> > Return NULL instead of 0, if card with given driverId is not found.
> >
> > Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
>
> Greg,
>
> I was going to say something else here about there being a lot of
> printk's that maybe could be converted, but then I looked at the TODO
> file.
>
> >> * The icn, pcbit and act2000 drivers are dead, remove them in 2017
> >> after another longterm kernel has been released, just in the
> >> unlikely case someone still has this hardware.
>
> Do you want work done on a driver that's on it's way out?
If people want to "practice" on such a driver, it is fine with me.
thanks,
greg k-h
prev parent reply other threads:[~2016-09-17 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 7:17 [PATCH v2] Staging: i4l: Return NULL instead of 0 Sandhya Bankar
2016-09-17 19:20 ` [Outreachy kernel] " Julia Lawall
2016-09-17 21:15 ` Alison Schofield
2016-09-17 21:24 ` Alison Schofield
2016-09-17 21:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160917213623.GB31410@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amsfield22@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.