From: Anchal Jain <anchalj109@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, jon.nettleton@gmai
Subject: [PATCH] staging: olpc_dcon: Replace a bit shift by a use of BIT.
Date: Sun, 18 Sep 2016 12:16:40 +0530 [thread overview]
Message-ID: <20160918064513.GA3810@life-desktop> (raw)
This patch replaces bit shifting on 1 with the BIT(x) macro
as it's extensively used by other function in the file olpc_dcon.h .
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index 215e7ec..23a48a1 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -9,18 +9,18 @@
#define DCON_REG_ID 0
#define DCON_REG_MODE 1
-#define MODE_PASSTHRU (1<<0)
-#define MODE_SLEEP (1<<1)
-#define MODE_SLEEP_AUTO (1<<2)
-#define MODE_BL_ENABLE (1<<3)
-#define MODE_BLANK (1<<4)
-#define MODE_CSWIZZLE (1<<5)
-#define MODE_COL_AA (1<<6)
-#define MODE_MONO_LUMA (1<<7)
-#define MODE_SCAN_INT (1<<8)
-#define MODE_CLOCKDIV (1<<9)
-#define MODE_DEBUG (1<<14)
-#define MODE_SELFTEST (1<<15)
+#define MODE_PASSTHRU bit(0)
+#define MODE_SLEEP bit(1)
+#define MODE_SLEEP_AUTO bit(2)
+#define MODE_BL_ENABLE bit(3)
+#define MODE_BLANK bit(4)
+#define MODE_CSWIZZLE bit(5)
+#define MODE_COL_AA bit(6)
+#define MODE_MONO_LUMA bit(7)
+#define MODE_SCAN_INT bit(8)
+#define MODE_CLOCKDIV bit(9)
+#define MODE_DEBUG bit(14)
+#define MODE_SELFTEST bit(15)
#define DCON_REG_HRES 0x2
#define DCON_REG_HTOTAL 0x3
@@ -35,11 +35,11 @@
#define DCON_REG_MEM_OPT_B 0x42
/* Load Delay Locked Loop (DLL) settings for clock delay */
-#define MEM_DLL_CLOCK_DELAY (1<<0)
+#define MEM_DLL_CLOCK_DELAY bit(0)
/* Memory controller power down function */
-#define MEM_POWER_DOWN (1<<8)
+#define MEM_POWER_DOWN bit(8)
/* Memory controller software reset */
-#define MEM_SOFT_RESET (1<<0)
+#define MEM_SOFT_RESET bit(0)
/* Status values */
--
1.9.1
next reply other threads:[~2016-09-18 6:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 6:46 Anchal Jain [this message]
2016-09-18 10:41 ` [Outreachy kernel] [PATCH] staging: olpc_dcon: Replace a bit shift by a use of BIT Julia Lawall
2016-09-18 11:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918064513.GA3810@life-desktop \
--to=anchalj109@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jon.nettleton@gmai \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.