From: Greg KH <gregkh@linuxfoundation.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Anchal Jain <anchalj109@gmail.com>,
outreachy-kernel@googlegroups.com, jon.nettleton@gmail.com
Subject: Re: [Outreachy kernel] [PATCH] staging: olpc_dcon: Replace a bit shift by a use of BIT.
Date: Sun, 18 Sep 2016 13:10:28 +0200 [thread overview]
Message-ID: <20160918111028.GA18602@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1609181239060.3238@hadrien>
On Sun, Sep 18, 2016 at 12:41:05PM +0200, Julia Lawall wrote:
>
>
> On Sun, 18 Sep 2016, Anchal Jain wrote:
>
> > This patch replaces bit shifting on 1 with the BIT(x) macro
> > as it's extensively used by other function in the file olpc_dcon.h .
>
> I think you have already made this mistake before. The macro is BIT, not
> bit. This is a header file, so you can't compile the file directly, but
> you should be able to compile some file that includes it.
Ugh, I missed this one again, now reverted...
greg k-h
prev parent reply other threads:[~2016-09-18 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 6:46 [PATCH] staging: olpc_dcon: Replace a bit shift by a use of BIT Anchal Jain
2016-09-18 10:41 ` [Outreachy kernel] " Julia Lawall
2016-09-18 11:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918111028.GA18602@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anchalj109@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.