From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Namrata A Shettar <namrataashettar@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Malcolm Priestley <tvboxspy@gmail.com>,
Anson Jacob <ansonjacob.aj@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH v2 4/4] staging: vt6655: device_main: Break up multiple assignments
Date: Sun, 18 Sep 2016 12:41:40 +0200 [thread overview]
Message-ID: <20160918104140.GB10846@kroah.com> (raw)
In-Reply-To: <7452f9668c5132d600519456ac4f627ba94cad9a.1474187686.git.namrataashettar@gmail.com>
On Sun, Sep 18, 2016 at 02:35:53PM +0530, Namrata A Shettar wrote:
> Break up multiple assignments on the same line to resolve checkpatch
> issue.
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/vt6655/device_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index f109eea..86532ca 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -669,7 +669,8 @@ static void device_init_td1_ring(struct vnt_private *priv)
>
> if (i > 0)
> priv->apTD1Rings[i-1].next_desc = cpu_to_le32(priv->td1_pool_dma);
> - priv->apTailTD[1] = priv->apCurrTD[1] = &priv->apTD1Rings[0];
> + priv->apCurrTD[1] = &priv->apTD1Rings[0];
> + priv->apTailTD[1] = priv->apCurrTD[1];
Same problem here, please be careful with your indentation, always run
your patches through checkpatch.pl before sending them out so that
people don't have to remind you to run your patches through
checkpatch.pl before sending them out.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-18 10:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 9:04 [PATCH v2 0/4] staging: vt6655: Fix checkpatch issues Namrata A Shettar
2016-09-18 9:04 ` [PATCH v2 1/4] staging: vt6655: device_main: Replace NULL comparison with !x Namrata A Shettar
2016-09-18 9:05 ` [PATCH v2 2/4] staging: vt6655: device_main: Replace explicit NULL comparison Namrata A Shettar
2016-09-18 9:05 ` [PATCH v2 3/4] staging: vt6655: card: Break multiple assignments Namrata A Shettar
2016-09-18 10:40 ` Greg Kroah-Hartman
2016-09-18 10:54 ` Namrata A Shettar
2016-09-18 11:07 ` [Outreachy kernel] " Greg Kroah-Hartman
2016-09-18 11:13 ` Namrata A Shettar
2016-09-18 9:05 ` [PATCH v2 4/4] staging: vt6655: device_main: Break up " Namrata A Shettar
2016-09-18 10:41 ` Greg Kroah-Hartman [this message]
2016-09-18 10:56 ` Namrata A Shettar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918104140.GB10846@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ansonjacob.aj@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=hamohammed.sa@gmail.com \
--cc=namrataashettar@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.