Re: [Outreachy kernel] Re: [PATCH v2 3/4] staging: vt6655: card: Break multiple assignments

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sun, Sep 18, 2016 at 04:24:48PM +0530, Namrata A Shettar wrote:
> On Sun, Sep 18, 2016 at 12:40:59PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Sep 18, 2016 at 02:35:39PM +0530, Namrata A Shettar wrote:
> > > Break multiple assignments on same line to resolve checkpatch issue.
> > > 
> > > Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> > > ---
> > >  drivers/staging/vt6655/card.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> > > index afb1e8b..00e7858 100644
> > > --- a/drivers/staging/vt6655/card.c
> > > +++ b/drivers/staging/vt6655/card.c
> > > @@ -528,8 +528,10 @@ CARDvSafeResetTx(
> > >  	struct vnt_tx_desc *pCurrTD;
> > >  
> > >  	/* initialize TD index */
> > > -	priv->apTailTD[0] = priv->apCurrTD[0] = &(priv->apTD0Rings[0]);
> > > -	priv->apTailTD[1] = priv->apCurrTD[1] = &(priv->apTD1Rings[0]);
> > > +        priv->apCurrTD[0] = &(priv->apTD0Rings[0]);
> > > +	priv->apTailTD[0] = priv->apCurrTD[0];
> > > +        priv->apCurrTD[1] = &(priv->apTD1Rings[0]);
> > > +	priv->apTailTD[1] = priv->apCurrTD[1];
> > 
> > Does that look correct to you?
> > 
> > (hint, odd indentation)
> > 
> > And really, the original code is fine, I would recommend just leaving
> > this alone, it makes more sense as-is, don't you think?
> > 
> > thanks,
> > 
> > greg k-h
> 
> Does this hold true for any multiple assignments warning by running
> checkpatch.pl? or is it only for the change that has been made here?

Use your best judgement :)