From: Sam Van Den Berge <sam.van.den.berge@telenet.be>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: vinod.koul@intel.com, dmaengine@vger.kernel.org,
k.kozlowski@samsung.com, kgene@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices
Date: Sun, 18 Sep 2016 20:18:19 +0200 [thread overview]
Message-ID: <20160918181819.GA28721@sam-MacBookPro> (raw)
In-Reply-To: <b8d6e8a9-4807-0dc0-95c8-a4aca89f18e7@samsung.com>
On Fri, Sep 16, 2016 at 01:00:12PM +0200, Sylwester Nawrocki wrote:
> On 09/15/2016 09:41 PM, Sam Van Den Berge wrote:
> > @@ -445,10 +446,44 @@ static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = {
> > [DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
> > };
> >
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> > + /* TODO: DMACH_XD0 */
> > + /* TODO: DMACH_XD1 */
> > + { "3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
>
> Thanks for the patch, still device name needs to be changed here
> to "s3c2440-sdi".
Thanks for spotting this! I guess I was too focused on the "rx-tx" part
that I totally missed the missing leading "s". I will fix this in v3.
Sam.
WARNING: multiple messages have this Message-ID (diff)
From: sam.van.den.berge@telenet.be (Sam Van Den Berge)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices
Date: Sun, 18 Sep 2016 20:18:19 +0200 [thread overview]
Message-ID: <20160918181819.GA28721@sam-MacBookPro> (raw)
In-Reply-To: <b8d6e8a9-4807-0dc0-95c8-a4aca89f18e7@samsung.com>
On Fri, Sep 16, 2016 at 01:00:12PM +0200, Sylwester Nawrocki wrote:
> On 09/15/2016 09:41 PM, Sam Van Den Berge wrote:
> > @@ -445,10 +446,44 @@ static struct s3c24xx_dma_channel s3c2440_dma_channels[DMACH_MAX] = {
> > [DMACH_USB_EP4] = { S3C24XX_DMA_APB, true, S3C24XX_DMA_CHANREQ(4, 3), },
> > };
> >
> > +static const struct dma_slave_map s3c2440_dma_slave_map[] = {
> > + /* TODO: DMACH_XD0 */
> > + /* TODO: DMACH_XD1 */
> > + { "3c2440-sdi", "rx-tx", (void *)DMACH_SDI },
>
> Thanks for the patch, still device name needs to be changed here
> to "s3c2440-sdi".
Thanks for spotting this! I guess I was too focused on the "rx-tx" part
that I totally missed the missing leading "s". I will fix this in v3.
Sam.
next prev parent reply other threads:[~2016-09-18 18:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160915194202eucas1p2fa3c4d1c9713e3713f956e1b114e1525@eucas1p2.samsung.com>
2016-09-15 19:41 ` [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440 devices Sam Van Den Berge
2016-09-15 19:41 ` Sam Van Den Berge
2016-09-16 11:00 ` Sylwester Nawrocki
2016-09-16 11:00 ` Sylwester Nawrocki
2016-09-18 18:18 ` Sam Van Den Berge [this message]
2016-09-18 18:18 ` Sam Van Den Berge
2016-09-16 11:16 ` Krzysztof Kozlowski
2016-09-16 11:16 ` Krzysztof Kozlowski
2016-09-22 18:48 ` Sam Van Den Berge
2016-09-22 18:48 ` Sam Van Den Berge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918181819.GA28721@sam-MacBookPro \
--to=sam.van.den.berge@telenet.be \
--cc=dmaengine@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.