* [RFC PATCH v2 0/2] adding panel claa070wp03xg support for exynos
@ 2016-09-18 14:27 ` Randy Li
0 siblings, 0 replies; 12+ messages in thread
From: Randy Li @ 2016-09-18 14:27 UTC (permalink / raw)
To: dri-devel
Cc: linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc,
linux-kernel, thierry.reding, airlied, a.hajda, devicetree,
Randy Li
I am trying to add LCD panel with LVDS interface for exynos 4412 topeet
itop. That board using a bridge chip to convert the parallel RGB signal
to LVDS signal. I could make a fb0 node appear in system now. But I can't
make it work yet. redirecting the urandom to fb0 won't make anything
change in panel.
The timing for this panel is calcuated from Hyundai T7, but it looks
different to the vendor's kernel. But those timings settings is disabled, so
I decided not to use it.
I attach them as references:
/* From Hyundai T7 */
static struct s3cfb_lcd hs101h = {
.width = 1280,
.height = 800,
.bpp = 24,
.freq = 60,
.timing = {
.h_fp = 49,
.h_bp = 17,
.h_sw = 33,
.v_fp = 4,
.v_fpe = 1,
.v_bp = 15,
.v_bpe = 1,
.v_sw = 6,
},
.polarity = {
.rise_vclk = 0,
.inv_hsync = 1,
.inv_vsync = 1,
.inv_vden = 0,
},
};
/* From vendor */
static struct s3cfb_lcd dummy_mipi_lcd = {
.width = 800,
.height = 1280,
.bpp = 24,
.freq = 60,
.timing = {
.h_fp = 16,
.h_bp = 140,
.h_sw = 14,
.v_fp = 8,
//.v_fpe = 2,
.v_bp = 4,
//.v_bpe = 1,
.v_sw = 4,
.cmd_allow_len = 4,
},
.polarity = {
.rise_vclk = 0,
.inv_hsync = 0,
.inv_vsync = 0,
.inv_vden = 0,
},
}
Randy Li (2):
ARM: dts: samsung: add rga-lvds panel in itop elite
drm/panel: Add support for Chunghwa CLAA070WP03XG panel
.../display/panel/chunghwa,claa070wp03xg.txt | 7 +++
arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++-
drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++
3 files changed, 86 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
--
2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* [RFC PATCH v2 0/2] adding panel claa070wp03xg support for exynos
@ 2016-09-18 14:27 ` Randy Li
0 siblings, 0 replies; 12+ messages in thread
From: Randy Li @ 2016-09-18 14:27 UTC (permalink / raw)
To: linux-arm-kernel
I am trying to add LCD panel with LVDS interface for exynos 4412 topeet
itop. That board using a bridge chip to convert the parallel RGB signal
to LVDS signal. I could make a fb0 node appear in system now. But I can't
make it work yet. redirecting the urandom to fb0 won't make anything
change in panel.
The timing for this panel is calcuated from Hyundai T7, but it looks
different to the vendor's kernel. But those timings settings is disabled, so
I decided not to use it.
I attach them as references:
/* From Hyundai T7 */
static struct s3cfb_lcd hs101h = {
.width = 1280,
.height = 800,
.bpp = 24,
.freq = 60,
.timing = {
.h_fp = 49,
.h_bp = 17,
.h_sw = 33,
.v_fp = 4,
.v_fpe = 1,
.v_bp = 15,
.v_bpe = 1,
.v_sw = 6,
},
.polarity = {
.rise_vclk = 0,
.inv_hsync = 1,
.inv_vsync = 1,
.inv_vden = 0,
},
};
/* From vendor */
static struct s3cfb_lcd dummy_mipi_lcd = {
.width = 800,
.height = 1280,
.bpp = 24,
.freq = 60,
.timing = {
.h_fp = 16,
.h_bp = 140,
.h_sw = 14,
.v_fp = 8,
//.v_fpe = 2,
.v_bp = 4,
//.v_bpe = 1,
.v_sw = 4,
.cmd_allow_len = 4,
},
.polarity = {
.rise_vclk = 0,
.inv_hsync = 0,
.inv_vsync = 0,
.inv_vden = 0,
},
}
Randy Li (2):
ARM: dts: samsung: add rga-lvds panel in itop elite
drm/panel: Add support for Chunghwa CLAA070WP03XG panel
.../display/panel/chunghwa,claa070wp03xg.txt | 7 +++
arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++-
drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++
3 files changed, 86 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
--
2.7.4
^ permalink raw reply [flat|nested] 12+ messages in thread* [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
2016-09-18 14:27 ` Randy Li
@ 2016-09-18 14:27 ` Randy Li
-1 siblings, 0 replies; 12+ messages in thread
From: Randy Li @ 2016-09-18 14:27 UTC (permalink / raw)
To: dri-devel
Cc: linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc,
linux-kernel, thierry.reding, airlied, a.hajda, devicetree,
Randy Li
It is actually a lvds panel connected through a rga-lvds bridge.
The touchscreen is communicated with i2c bus but the driver is not
support now.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index b08705e..9ef0505 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -138,6 +138,36 @@
assigned-clocks = <&clock CLK_MOUT_CAM0>;
assigned-clock-parents = <&clock CLK_XUSBXTI>;
};
+
+ vcc_sys_lcd: sys-lcd {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_5v";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
+ };
+
+ panel: panel@0 {
+ compatible = "chunghwa,claa070wp03xg";
+
+ power-supply = <&vcc_sys_lcd>;
+ enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
+ backlight = <&bl>;
+
+ port {
+ lcd_ep: endpoint {
+ remote-endpoint = <&rga_lvds>;
+ };
+ };
+ };
+
+ bl: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 5 12 16 32 64 128 255>;
+ default-brightness-level = <5>;
+ power-supply = <&vcc_sys_lcd>;
+ };
};
&adc {
@@ -215,9 +245,9 @@
&pwm {
status = "okay";
- pinctrl-0 = <&pwm0_out>;
+ pinctrl-0 = <&pwm0_out &pwm1_out>;
pinctrl-names = "default";
- samsung,pwm-outputs = <0>;
+ samsung,pwm-outputs = <0>, <1>;
};
&sdhci_2 {
@@ -238,3 +268,23 @@
&serial_2 {
status = "okay";
};
+
+&i2c_3 {
+ status = "okay";
+};
+
+&fimd {
+ pinctrl-0 = <&lcd_clk &lcd_data24>;
+ pinctrl-names = "default";
+ status = "okay";
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@3 {
+ reg = <3>;
+ rga_lvds: endpoint {
+ remote-endpoint = <&lcd_ep>;
+ };
+ };
+ };
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
@ 2016-09-18 14:27 ` Randy Li
0 siblings, 0 replies; 12+ messages in thread
From: Randy Li @ 2016-09-18 14:27 UTC (permalink / raw)
To: linux-arm-kernel
It is actually a lvds panel connected through a rga-lvds bridge.
The touchscreen is communicated with i2c bus but the driver is not
support now.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
1 file changed, 52 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index b08705e..9ef0505 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -138,6 +138,36 @@
assigned-clocks = <&clock CLK_MOUT_CAM0>;
assigned-clock-parents = <&clock CLK_XUSBXTI>;
};
+
+ vcc_sys_lcd: sys-lcd {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_5v";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
+ };
+
+ panel: panel at 0 {
+ compatible = "chunghwa,claa070wp03xg";
+
+ power-supply = <&vcc_sys_lcd>;
+ enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
+ backlight = <&bl>;
+
+ port {
+ lcd_ep: endpoint {
+ remote-endpoint = <&rga_lvds>;
+ };
+ };
+ };
+
+ bl: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
+ brightness-levels = <0 5 12 16 32 64 128 255>;
+ default-brightness-level = <5>;
+ power-supply = <&vcc_sys_lcd>;
+ };
};
&adc {
@@ -215,9 +245,9 @@
&pwm {
status = "okay";
- pinctrl-0 = <&pwm0_out>;
+ pinctrl-0 = <&pwm0_out &pwm1_out>;
pinctrl-names = "default";
- samsung,pwm-outputs = <0>;
+ samsung,pwm-outputs = <0>, <1>;
};
&sdhci_2 {
@@ -238,3 +268,23 @@
&serial_2 {
status = "okay";
};
+
+&i2c_3 {
+ status = "okay";
+};
+
+&fimd {
+ pinctrl-0 = <&lcd_clk &lcd_data24>;
+ pinctrl-names = "default";
+ status = "okay";
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port at 3 {
+ reg = <3>;
+ rga_lvds: endpoint {
+ remote-endpoint = <&lcd_ep>;
+ };
+ };
+ };
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
2016-09-18 14:27 ` Randy Li
@ 2016-09-18 19:03 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-09-18 19:03 UTC (permalink / raw)
To: Randy Li
Cc: dri-devel, linux, kgene, krzk, linux-arm-kernel,
linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda,
devicetree
On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> It is actually a lvds panel connected through a rga-lvds bridge.
> The touchscreen is communicated with i2c bus but the driver is not
> support now.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
Subject: ARM: dts: exynos
> ---
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
> 1 file changed, 52 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index b08705e..9ef0505 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -138,6 +138,36 @@
> assigned-clocks = <&clock CLK_MOUT_CAM0>;
> assigned-clock-parents = <&clock CLK_XUSBXTI>;
> };
> +
> + vcc_sys_lcd: sys-lcd {
No underscores, use hyphens.
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_5v";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
Isn't this one of S5M8767 PMIC regulators? If so, then it should be
defined there... On the other hand, the PMIC supports GPIO enable
control only for buck9...
> + };
> +
> + panel: panel@0 {
> + compatible = "chunghwa,claa070wp03xg";
> +
> + power-supply = <&vcc_sys_lcd>;
> + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
> + backlight = <&bl>;
> +
> + port {
> + lcd_ep: endpoint {
lcd-ep
> + remote-endpoint = <&rga_lvds>;
> + };
> + };
> + };
> +
> + bl: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
> + brightness-levels = <0 5 12 16 32 64 128 255>;
> + default-brightness-level = <5>;
> + power-supply = <&vcc_sys_lcd>;
> + };
> };
>
> &adc {
> @@ -215,9 +245,9 @@
>
> &pwm {
> status = "okay";
> - pinctrl-0 = <&pwm0_out>;
> + pinctrl-0 = <&pwm0_out &pwm1_out>;
> pinctrl-names = "default";
> - samsung,pwm-outputs = <0>;
> + samsung,pwm-outputs = <0>, <1>;
> };
>
> &sdhci_2 {
> @@ -238,3 +268,23 @@
> &serial_2 {
> status = "okay";
> };
> +
> +&i2c_3 {
> + status = "okay";
> +};
> +
> +&fimd {
Please put these nodes in alphabetical order. I asked about it for
initial DTS and it applies still.
> + pinctrl-0 = <&lcd_clk &lcd_data24>;
> + pinctrl-names = "default";
> + status = "okay";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@3 {
> + reg = <3>;
> + rga_lvds: endpoint {
rga-lvds
Best regards,
Krzysztof
> + remote-endpoint = <&lcd_ep>;
> + };
> + };
> + };
> +};
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
@ 2016-09-18 19:03 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-09-18 19:03 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> It is actually a lvds panel connected through a rga-lvds bridge.
> The touchscreen is communicated with i2c bus but the driver is not
> support now.
>
> Signed-off-by: Randy Li <ayaka@soulik.info>
Subject: ARM: dts: exynos
> ---
> arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
> 1 file changed, 52 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index b08705e..9ef0505 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -138,6 +138,36 @@
> assigned-clocks = <&clock CLK_MOUT_CAM0>;
> assigned-clock-parents = <&clock CLK_XUSBXTI>;
> };
> +
> + vcc_sys_lcd: sys-lcd {
No underscores, use hyphens.
> + compatible = "regulator-fixed";
> + regulator-name = "vcc_5v";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
Isn't this one of S5M8767 PMIC regulators? If so, then it should be
defined there... On the other hand, the PMIC supports GPIO enable
control only for buck9...
> + };
> +
> + panel: panel at 0 {
> + compatible = "chunghwa,claa070wp03xg";
> +
> + power-supply = <&vcc_sys_lcd>;
> + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
> + backlight = <&bl>;
> +
> + port {
> + lcd_ep: endpoint {
lcd-ep
> + remote-endpoint = <&rga_lvds>;
> + };
> + };
> + };
> +
> + bl: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
> + brightness-levels = <0 5 12 16 32 64 128 255>;
> + default-brightness-level = <5>;
> + power-supply = <&vcc_sys_lcd>;
> + };
> };
>
> &adc {
> @@ -215,9 +245,9 @@
>
> &pwm {
> status = "okay";
> - pinctrl-0 = <&pwm0_out>;
> + pinctrl-0 = <&pwm0_out &pwm1_out>;
> pinctrl-names = "default";
> - samsung,pwm-outputs = <0>;
> + samsung,pwm-outputs = <0>, <1>;
> };
>
> &sdhci_2 {
> @@ -238,3 +268,23 @@
> &serial_2 {
> status = "okay";
> };
> +
> +&i2c_3 {
> + status = "okay";
> +};
> +
> +&fimd {
Please put these nodes in alphabetical order. I asked about it for
initial DTS and it applies still.
> + pinctrl-0 = <&lcd_clk &lcd_data24>;
> + pinctrl-names = "default";
> + status = "okay";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port at 3 {
> + reg = <3>;
> + rga_lvds: endpoint {
rga-lvds
Best regards,
Krzysztof
> + remote-endpoint = <&lcd_ep>;
> + };
> + };
> + };
> +};
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
2016-09-18 19:03 ` Krzysztof Kozlowski
(?)
@ 2016-09-18 19:09 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-09-18 19:09 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Randy Li, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-I+IVW8TIWO2tmTQ+vhA3Yw, kgene-DgEjT+Ai2ygdnm+yROfE0A,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, airlied-cv59FeDIM0c,
a.hajda-Sze3O3UU22JBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA
On Sun, Sep 18, 2016 at 09:03:48PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> > It is actually a lvds panel connected through a rga-lvds bridge.
> > The touchscreen is communicated with i2c bus but the driver is not
> > support now.
> >
> > Signed-off-by: Randy Li <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
>
> Subject: ARM: dts: exynos
>
> > ---
> > arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
> > 1 file changed, 52 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > index b08705e..9ef0505 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > @@ -138,6 +138,36 @@
> > assigned-clocks = <&clock CLK_MOUT_CAM0>;
> > assigned-clock-parents = <&clock CLK_XUSBXTI>;
> > };
> > +
> > + vcc_sys_lcd: sys-lcd {
>
> No underscores, use hyphens.
Ah wait, it's a label, so underscore seems ok. My mistake.
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_5v";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
>
> Isn't this one of S5M8767 PMIC regulators? If so, then it should be
> defined there... On the other hand, the PMIC supports GPIO enable
> control only for buck9...
>
> > + };
> > +
> > + panel: panel@0 {
> > + compatible = "chunghwa,claa070wp03xg";
> > +
> > + power-supply = <&vcc_sys_lcd>;
> > + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
> > + backlight = <&bl>;
> > +
> > + port {
> > + lcd_ep: endpoint {
>
> lcd-ep
No need, the same.
Best regards,
Krzysztof
>
> > + remote-endpoint = <&rga_lvds>;
> > + };
> > + };
> > + };
> > +
> > + bl: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
> > + brightness-levels = <0 5 12 16 32 64 128 255>;
> > + default-brightness-level = <5>;
> > + power-supply = <&vcc_sys_lcd>;
> > + };
> > };
> >
> > &adc {
> > @@ -215,9 +245,9 @@
> >
> > &pwm {
> > status = "okay";
> > - pinctrl-0 = <&pwm0_out>;
> > + pinctrl-0 = <&pwm0_out &pwm1_out>;
> > pinctrl-names = "default";
> > - samsung,pwm-outputs = <0>;
> > + samsung,pwm-outputs = <0>, <1>;
> > };
> >
> > &sdhci_2 {
> > @@ -238,3 +268,23 @@
> > &serial_2 {
> > status = "okay";
> > };
> > +
> > +&i2c_3 {
> > + status = "okay";
> > +};
> > +
> > +&fimd {
>
> Please put these nodes in alphabetical order. I asked about it for
> initial DTS and it applies still.
>
> > + pinctrl-0 = <&lcd_clk &lcd_data24>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@3 {
> > + reg = <3>;
> > + rga_lvds: endpoint {
>
> rga-lvds
>
> Best regards,
> Krzysztof
>
> > + remote-endpoint = <&lcd_ep>;
> > + };
> > + };
> > + };
> > +};
> > --
> > 2.7.4
> >
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
@ 2016-09-18 19:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-09-18 19:09 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Randy Li, dri-devel, linux, kgene, linux-arm-kernel,
linux-samsung-soc, linux-kernel, thierry.reding, airlied, a.hajda,
devicetree
On Sun, Sep 18, 2016 at 09:03:48PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> > It is actually a lvds panel connected through a rga-lvds bridge.
> > The touchscreen is communicated with i2c bus but the driver is not
> > support now.
> >
> > Signed-off-by: Randy Li <ayaka@soulik.info>
>
> Subject: ARM: dts: exynos
>
> > ---
> > arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
> > 1 file changed, 52 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > index b08705e..9ef0505 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > @@ -138,6 +138,36 @@
> > assigned-clocks = <&clock CLK_MOUT_CAM0>;
> > assigned-clock-parents = <&clock CLK_XUSBXTI>;
> > };
> > +
> > + vcc_sys_lcd: sys-lcd {
>
> No underscores, use hyphens.
Ah wait, it's a label, so underscore seems ok. My mistake.
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_5v";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
>
> Isn't this one of S5M8767 PMIC regulators? If so, then it should be
> defined there... On the other hand, the PMIC supports GPIO enable
> control only for buck9...
>
> > + };
> > +
> > + panel: panel@0 {
> > + compatible = "chunghwa,claa070wp03xg";
> > +
> > + power-supply = <&vcc_sys_lcd>;
> > + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
> > + backlight = <&bl>;
> > +
> > + port {
> > + lcd_ep: endpoint {
>
> lcd-ep
No need, the same.
Best regards,
Krzysztof
>
> > + remote-endpoint = <&rga_lvds>;
> > + };
> > + };
> > + };
> > +
> > + bl: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
> > + brightness-levels = <0 5 12 16 32 64 128 255>;
> > + default-brightness-level = <5>;
> > + power-supply = <&vcc_sys_lcd>;
> > + };
> > };
> >
> > &adc {
> > @@ -215,9 +245,9 @@
> >
> > &pwm {
> > status = "okay";
> > - pinctrl-0 = <&pwm0_out>;
> > + pinctrl-0 = <&pwm0_out &pwm1_out>;
> > pinctrl-names = "default";
> > - samsung,pwm-outputs = <0>;
> > + samsung,pwm-outputs = <0>, <1>;
> > };
> >
> > &sdhci_2 {
> > @@ -238,3 +268,23 @@
> > &serial_2 {
> > status = "okay";
> > };
> > +
> > +&i2c_3 {
> > + status = "okay";
> > +};
> > +
> > +&fimd {
>
> Please put these nodes in alphabetical order. I asked about it for
> initial DTS and it applies still.
>
> > + pinctrl-0 = <&lcd_clk &lcd_data24>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port@3 {
> > + reg = <3>;
> > + rga_lvds: endpoint {
>
> rga-lvds
>
> Best regards,
> Krzysztof
>
> > + remote-endpoint = <&lcd_ep>;
> > + };
> > + };
> > + };
> > +};
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 12+ messages in thread* [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite
@ 2016-09-18 19:09 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2016-09-18 19:09 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Sep 18, 2016 at 09:03:48PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> > It is actually a lvds panel connected through a rga-lvds bridge.
> > The touchscreen is communicated with i2c bus but the driver is not
> > support now.
> >
> > Signed-off-by: Randy Li <ayaka@soulik.info>
>
> Subject: ARM: dts: exynos
>
> > ---
> > arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++++++++++++++++++++++++++--
> > 1 file changed, 52 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > index b08705e..9ef0505 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > @@ -138,6 +138,36 @@
> > assigned-clocks = <&clock CLK_MOUT_CAM0>;
> > assigned-clock-parents = <&clock CLK_XUSBXTI>;
> > };
> > +
> > + vcc_sys_lcd: sys-lcd {
>
> No underscores, use hyphens.
Ah wait, it's a label, so underscore seems ok. My mistake.
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc_5v";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + gpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;
>
> Isn't this one of S5M8767 PMIC regulators? If so, then it should be
> defined there... On the other hand, the PMIC supports GPIO enable
> control only for buck9...
>
> > + };
> > +
> > + panel: panel at 0 {
> > + compatible = "chunghwa,claa070wp03xg";
> > +
> > + power-supply = <&vcc_sys_lcd>;
> > + enable-gpios = <&gpl0 2 GPIO_ACTIVE_HIGH>;
> > + backlight = <&bl>;
> > +
> > + port {
> > + lcd_ep: endpoint {
>
> lcd-ep
No need, the same.
Best regards,
Krzysztof
>
> > + remote-endpoint = <&rga_lvds>;
> > + };
> > + };
> > + };
> > +
> > + bl: backlight {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm 1 5000000 PWM_POLARITY_INVERTED>;
> > + brightness-levels = <0 5 12 16 32 64 128 255>;
> > + default-brightness-level = <5>;
> > + power-supply = <&vcc_sys_lcd>;
> > + };
> > };
> >
> > &adc {
> > @@ -215,9 +245,9 @@
> >
> > &pwm {
> > status = "okay";
> > - pinctrl-0 = <&pwm0_out>;
> > + pinctrl-0 = <&pwm0_out &pwm1_out>;
> > pinctrl-names = "default";
> > - samsung,pwm-outputs = <0>;
> > + samsung,pwm-outputs = <0>, <1>;
> > };
> >
> > &sdhci_2 {
> > @@ -238,3 +268,23 @@
> > &serial_2 {
> > status = "okay";
> > };
> > +
> > +&i2c_3 {
> > + status = "okay";
> > +};
> > +
> > +&fimd {
>
> Please put these nodes in alphabetical order. I asked about it for
> initial DTS and it applies still.
>
> > + pinctrl-0 = <&lcd_clk &lcd_data24>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + port at 3 {
> > + reg = <3>;
> > + rga_lvds: endpoint {
>
> rga-lvds
>
> Best regards,
> Krzysztof
>
> > + remote-endpoint = <&lcd_ep>;
> > + };
> > + };
> > + };
> > +};
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* [RFC PATCH v2 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel
2016-09-18 14:27 ` Randy Li
@ 2016-09-18 14:27 ` Randy Li
-1 siblings, 0 replies; 12+ messages in thread
From: Randy Li @ 2016-09-18 14:27 UTC (permalink / raw)
To: dri-devel
Cc: linux, kgene, krzk, linux-arm-kernel, linux-samsung-soc,
linux-kernel, thierry.reding, airlied, a.hajda, devicetree,
Randy Li
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be
supported by the simple panel driver.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++
drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++
2 files changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
new file mode 100644
index 0000000..dd22685
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
@@ -0,0 +1,7 @@
+Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
+
+Required properties:
+- compatible: should be "chunghwa,claa070wp03xg"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f178998..3204e6b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -583,6 +583,30 @@ static const struct panel_desc avic_tm070ddh03 = {
},
};
+static const struct drm_display_mode chunghwa_claa070wp03xg_mode = {
+ .clock = 66770,
+ .hdisplay = 800,
+ .hsync_start = 800 + 49,
+ .hsync_end = 800 + 49 + 33,
+ .htotal = 800 + 49 + 33 + 17,
+ .vdisplay = 1280,
+ .vsync_start = 1280 + 1,
+ .vsync_end = 1280 + 1 + 7,
+ .vtotal = 1280 + 1 + 7 + 15,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc chunghwa_claa070wp03xg = {
+ .modes = &chunghwa_claa070wp03xg_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 94,
+ .height = 150,
+ },
+};
+
static const struct drm_display_mode chunghwa_claa101wa01a_mode = {
.clock = 72070,
.hdisplay = 1366,
@@ -1544,6 +1568,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "avic,tm070ddh03",
.data = &avic_tm070ddh03,
}, {
+ .compatible = "chunghwa,claa070wp03xg",
+ .data = &chunghwa_claa070wp03xg,
+ }, {
.compatible = "chunghwa,claa101wa01a",
.data = &chunghwa_claa101wa01a
}, {
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* [RFC PATCH v2 2/2] drm/panel: Add support for Chunghwa CLAA070WP03XG panel
@ 2016-09-18 14:27 ` Randy Li
0 siblings, 0 replies; 12+ messages in thread
From: Randy Li @ 2016-09-18 14:27 UTC (permalink / raw)
To: linux-arm-kernel
The Chunghwa CLAA070WP03XG is a 7" 1280x800 panel, which can be
supported by the simple panel driver.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
.../display/panel/chunghwa,claa070wp03xg.txt | 7 ++++++
drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++++++++
2 files changed, 34 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
diff --git a/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
new file mode 100644
index 0000000..dd22685
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/chunghwa,claa070wp03xg.txt
@@ -0,0 +1,7 @@
+Chunghwa Picture Tubes Ltd. 7" WXGA TFT LCD panel
+
+Required properties:
+- compatible: should be "chunghwa,claa070wp03xg"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index f178998..3204e6b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -583,6 +583,30 @@ static const struct panel_desc avic_tm070ddh03 = {
},
};
+static const struct drm_display_mode chunghwa_claa070wp03xg_mode = {
+ .clock = 66770,
+ .hdisplay = 800,
+ .hsync_start = 800 + 49,
+ .hsync_end = 800 + 49 + 33,
+ .htotal = 800 + 49 + 33 + 17,
+ .vdisplay = 1280,
+ .vsync_start = 1280 + 1,
+ .vsync_end = 1280 + 1 + 7,
+ .vtotal = 1280 + 1 + 7 + 15,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc chunghwa_claa070wp03xg = {
+ .modes = &chunghwa_claa070wp03xg_mode,
+ .num_modes = 1,
+ .bpc = 6,
+ .size = {
+ .width = 94,
+ .height = 150,
+ },
+};
+
static const struct drm_display_mode chunghwa_claa101wa01a_mode = {
.clock = 72070,
.hdisplay = 1366,
@@ -1544,6 +1568,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "avic,tm070ddh03",
.data = &avic_tm070ddh03,
}, {
+ .compatible = "chunghwa,claa070wp03xg",
+ .data = &chunghwa_claa070wp03xg,
+ }, {
.compatible = "chunghwa,claa101wa01a",
.data = &chunghwa_claa101wa01a
}, {
--
2.7.4
^ permalink raw reply related [flat|nested] 12+ messages in thread