All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
	darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
	linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 4/6] fs: add iomap_file_dirty
Date: Mon, 19 Sep 2016 10:11:44 +1000	[thread overview]
Message-ID: <20160919001143.GU30497@dastard> (raw)
In-Reply-To: <20160905145751.GC7662-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

On Mon, Sep 05, 2016 at 07:57:51AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 25, 2016 at 04:31:07PM -0700, Christoph Hellwig wrote:
> > Originally-from: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> 
> This should be a
> 
> From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> 
> so that git picks up authorship information correctly.
> 
> > XXX: might want a bigger name, and possible a better implementation
> > that doesn't require two lookups in the radix tree.
> 
> And these need to be looked into.  I can take a stab at it, but I need
> to get a few other things off my plate first.

Seeing as it works and isn't too ugly to live, I think I'm going to
merge this as is. When a better implementation comes along we
can replace it with that...

Cheers,

Dave.
-- 
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
	viro@ZenIV.linux.org.uk, darrick.wong@oracle.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	xfs@oss.sgi.com, linux-api@vger.kernel.org
Subject: Re: [PATCH 4/6] fs: add iomap_file_dirty
Date: Mon, 19 Sep 2016 10:11:44 +1000	[thread overview]
Message-ID: <20160919001143.GU30497@dastard> (raw)
In-Reply-To: <20160905145751.GC7662@infradead.org>

On Mon, Sep 05, 2016 at 07:57:51AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 25, 2016 at 04:31:07PM -0700, Christoph Hellwig wrote:
> > Originally-from: Christoph Hellwig <hch@lst.de>
> 
> This should be a
> 
> From: Christoph Hellwig <hch@lst.de>
> 
> so that git picks up authorship information correctly.
> 
> > XXX: might want a bigger name, and possible a better implementation
> > that doesn't require two lookups in the radix tree.
> 
> And these need to be looked into.  I can take a stab at it, but I need
> to get a few other things off my plate first.

Seeing as it works and isn't too ugly to live, I think I'm going to
merge this as is. When a better implementation comes along we
can replace it with that...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

  parent reply	other threads:[~2016-09-19  0:11 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 23:30 [PATCH v8 0/6] vfs: help support reflink for XFS Darrick J. Wong
2016-08-25 23:30 ` Darrick J. Wong
2016-08-25 23:30 ` [PATCH 1/6] vfs: fix return type of ioctl_file_dedupe_range Darrick J. Wong
2016-08-25 23:30   ` Darrick J. Wong
2016-08-25 23:30 ` [PATCH 2/6] vfs: cap dedupe request structure size at PAGE_SIZE Darrick J. Wong
2016-08-25 23:30   ` Darrick J. Wong
     [not found]   ` <147216785429.525.1965983896010934181.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-09-05 14:55     ` Christoph Hellwig
2016-09-05 14:55       ` Christoph Hellwig
2016-09-05 14:55       ` Christoph Hellwig
     [not found]       ` <20160905145549.GA7662-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-09-13  1:16         ` Darrick J. Wong
2016-09-13  1:16           ` Darrick J. Wong
2016-09-13  1:16           ` Darrick J. Wong
2016-09-14 20:22           ` Christoph Hellwig
2016-08-25 23:31 ` [PATCH 3/6] vfs: support FS_XFLAG_REFLINK and FS_XFLAG_COWEXTSIZE Darrick J. Wong
2016-08-25 23:31   ` Darrick J. Wong
     [not found]   ` <147216786073.525.16014208838990530622.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-09-05 14:56     ` Christoph Hellwig
2016-09-05 14:56       ` Christoph Hellwig
2016-09-05 14:56       ` Christoph Hellwig
     [not found]       ` <20160905145622.GB7662-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-09-06 19:15         ` Darrick J. Wong
2016-09-06 19:15           ` Darrick J. Wong
2016-09-06 19:15           ` Darrick J. Wong
2016-09-11 12:58           ` Christoph Hellwig
2016-09-12 19:12             ` Darrick J. Wong
2016-09-12 19:12               ` Darrick J. Wong
2016-08-25 23:31 ` [PATCH 4/6] fs: add iomap_file_dirty Christoph Hellwig
2016-08-25 23:31   ` Christoph Hellwig
2016-09-05 14:57   ` Christoph Hellwig
2016-09-05 14:57     ` Christoph Hellwig
2016-09-06 17:34     ` Darrick J. Wong
2016-09-06 17:34       ` Darrick J. Wong
2016-09-11 12:58       ` Christoph Hellwig
     [not found]     ` <20160905145751.GC7662-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-09-19  0:11       ` Dave Chinner [this message]
2016-09-19  0:11         ` Dave Chinner
2016-08-25 23:31 ` [PATCH 5/6] iomap: don't set FIEMAP_EXTENT_MERGED for extent based filesystems Darrick J. Wong
2016-08-25 23:31   ` Darrick J. Wong
     [not found] ` <147216784041.525.7722906502172299465.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-08-25 23:31   ` [PATCH 6/6] iomap: add a flag to report shared extents Darrick J. Wong
2016-08-25 23:31     ` Darrick J. Wong
2016-08-25 23:31     ` Darrick J. Wong
2016-09-05 14:58     ` Christoph Hellwig
2016-09-05 14:58       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160919001143.GU30497@dastard \
    --to=david-fqsqvqoi3ljby3ivrkzq2a@public.gmane.org \
    --cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    --cc=xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.