From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: "Koenig, Christian" <Christian.Koenig-5C7GfCeVMHo@public.gmane.org>
Cc: "Deucher,
Alexander" <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org>,
"Wang, Ken" <Ken.Wang-5C7GfCeVMHo@public.gmane.org>,
"Liu, Monk" <Monk.Liu-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/si: remove unused interface which caused build issue
Date: Mon, 19 Sep 2016 16:37:19 +0800 [thread overview]
Message-ID: <20160919083719.GA2961@hr-amur2> (raw)
In-Reply-To: <47fdee91-13bb-ff81-2fec-762238bfa32f-5C7GfCeVMHo@public.gmane.org>
On Mon, Sep 19, 2016 at 04:31:18PM +0800, Koenig, Christian wrote:
> Am 19.09.2016 um 10:11 schrieb Huang Rui:
> > From: Huang Rui <Ray.Huang@amd.com>
> >
> > Fix commit (ed22ee2 drm/amdgpu:changes of virtualization cases probe)
> > regression, remove si_get_virtual_caps because the callback is removed
> > at amdgpu_asic_funcs.
> >
> > Signed-off-by: Huang Rui <Ray.Huang@amd.com>
> > Cc: Monk Liu <Monk.Liu@amd.com>
>
> Patch is Reviewed-by: Christian K?nig <christian.koenig@amd.com>.
>
> Please always build with all HW generations enabled to catch such errors.
>
Yep, agree. I guess CONFIG_DRM_AMDGPU_SI might not be set as default, so
some guys didn't find it.
Thanks,
Rui
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-09-19 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:11 [PATCH] drm/amdgpu/si: remove unused interface which caused build issue Huang Rui
[not found] ` <1474272705-32265-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org>
2016-09-19 8:26 ` Liu, Monk
2016-09-19 8:31 ` Christian König
[not found] ` <47fdee91-13bb-ff81-2fec-762238bfa32f-5C7GfCeVMHo@public.gmane.org>
2016-09-19 8:37 ` Huang Rui [this message]
2016-09-19 14:18 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919083719.GA2961@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=Alexander.Deucher-5C7GfCeVMHo@public.gmane.org \
--cc=Christian.Koenig-5C7GfCeVMHo@public.gmane.org \
--cc=Ken.Wang-5C7GfCeVMHo@public.gmane.org \
--cc=Monk.Liu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.