Re: [PATCH] drm/amdgpu/si: remove unused interface which caused build issue

["Christian König" <christian.koenig-5C7GfCeVMHo@public.gmane.org>]

Am 19.09.2016 um 10:11 schrieb Huang Rui:
> From: Huang Rui <Ray.Huang@amd.com>
>
> Fix commit (ed22ee2 drm/amdgpu:changes of virtualization cases probe)
> regression, remove si_get_virtual_caps because the callback is removed
> at amdgpu_asic_funcs.
>
> Signed-off-by: Huang Rui <Ray.Huang@amd.com>
> Cc: Monk Liu <Monk.Liu@amd.com>

Patch is Reviewed-by: Christian König <christian.koenig@amd.com>.

Please always build with all HW generations enabled to catch such errors.

Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/si.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
> index fee76b8..a0b6b7e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si.c
> @@ -952,12 +952,6 @@ static void si_smc_wreg(struct amdgpu_device *adev, u32 reg, u32 v)
>   	spin_unlock_irqrestore(&adev->smc_idx_lock, flags);
>   }
>   
> -static u32 si_get_virtual_caps(struct amdgpu_device *adev)
> -{
> -	/* SI does not support SR-IOV */
> -	return 0;
> -}
> -
>   static struct amdgpu_allowed_register_entry si_allowed_read_registers[] = {
>   	{GRBM_STATUS, false},
>   	{GB_ADDR_CONFIG, false},
> @@ -1133,7 +1127,6 @@ static const struct amdgpu_asic_funcs si_asic_funcs =
>   	.get_xclk = &si_get_xclk,
>   	.set_uvd_clocks = &si_set_uvd_clocks,
>   	.set_vce_clocks = NULL,
> -	.get_virtual_caps = &si_get_virtual_caps,
>   };
>   
>   static uint32_t si_get_rev_id(struct amdgpu_device *adev)


_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx