From: Eduardo Otubo <eduardo.otubo@profitbricks.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Brian Rak <brak@gameservers.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] seccomp missing calls in 2.7.0?
Date: Mon, 19 Sep 2016 11:47:37 +0200 [thread overview]
Message-ID: <20160919094737.GA12424@vader> (raw)
In-Reply-To: <874m5ckyt0.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Mon, Sep 19, 2016 at 11=45=47AM +0200, Markus Armbruster wrote:
> Brian Rak <brak@gameservers.com> writes:
>
> > getrusage is used in a number of places throughout the qemu codebase
> > (notably, in crypto/pbkdf.c).
> > Without this syscall being whitelisted, qemu ends up getting killed by
> > the kernel whenever you
> > try to connect to a VNC console.
>
> The body of the commit message now looks good to me, but the headline is
> still off. It should be something like "seccomp: Add getrusage() to
> whitelist".
>
> Perhaps Eduardo is willing to touch it up on commit. If not, you need
> to resend your patch as a top-level message (not in reply to anything)
> with the subject fixed. Please consider using git-send-email. Thanks!
>
> http://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches
Yep, that's not a problem now. I'll fix that. But yeah, please stick to
the guidelines next time :)
Regards,
--
Eduardo Otubo
ProfitBricks GmbH
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-09-19 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 15:27 [Qemu-devel] seccomp missing calls in 2.7.0? Brian Rak
2016-09-06 16:43 ` Eduardo Otubo
2016-09-07 19:55 ` Brian Rak
2016-09-13 8:12 ` Eduardo Otubo
2016-09-13 19:17 ` Brian Rak
2016-09-19 9:45 ` Markus Armbruster
2016-09-19 9:47 ` Eduardo Otubo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919094737.GA12424@vader \
--to=eduardo.otubo@profitbricks.com \
--cc=armbru@redhat.com \
--cc=brak@gameservers.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.