From: Markus Armbruster <armbru@redhat.com>
To: Brian Rak <brak@gameservers.com>
Cc: Eduardo Otubo <eduardo.otubo@profitbricks.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] seccomp missing calls in 2.7.0?
Date: Mon, 19 Sep 2016 11:45:47 +0200 [thread overview]
Message-ID: <874m5ckyt0.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <f526ac72-1864-3f35-666d-bce4d93d15e5@gameservers.com> (Brian Rak's message of "Tue, 13 Sep 2016 15:17:52 -0400")
Brian Rak <brak@gameservers.com> writes:
> getrusage is used in a number of places throughout the qemu codebase
> (notably, in crypto/pbkdf.c).
> Without this syscall being whitelisted, qemu ends up getting killed by
> the kernel whenever you
> try to connect to a VNC console.
The body of the commit message now looks good to me, but the headline is
still off. It should be something like "seccomp: Add getrusage() to
whitelist".
Perhaps Eduardo is willing to touch it up on commit. If not, you need
to resend your patch as a top-level message (not in reply to anything)
with the subject fixed. Please consider using git-send-email. Thanks!
http://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches
next prev parent reply other threads:[~2016-09-19 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 15:27 [Qemu-devel] seccomp missing calls in 2.7.0? Brian Rak
2016-09-06 16:43 ` Eduardo Otubo
2016-09-07 19:55 ` Brian Rak
2016-09-13 8:12 ` Eduardo Otubo
2016-09-13 19:17 ` Brian Rak
2016-09-19 9:45 ` Markus Armbruster [this message]
2016-09-19 9:47 ` Eduardo Otubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m5ckyt0.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=brak@gameservers.com \
--cc=eduardo.otubo@profitbricks.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.