* [PATCH] staging: iio: meter: ade7754: Match alignment with open parenthesis
@ 2016-09-19 11:36 Georgiana Rodica Chelu
2016-09-19 11:41 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Georgiana Rodica Chelu @ 2016-09-19 11:36 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
drivers/staging/iio/meter/ade7754.c | 59 +++++++++++++++++--------------------
1 file changed, 27 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7754.c b/drivers/staging/iio/meter/ade7754.c
index c46bef64..4e93987 100644
--- a/drivers/staging/iio/meter/ade7754.c
+++ b/drivers/staging/iio/meter/ade7754.c
@@ -24,8 +24,8 @@
#include "ade7754.h"
static int ade7754_spi_write_reg_8(struct device *dev,
- u8 reg_address,
- u8 val)
+ u8 reg_address,
+ u8 val)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -42,8 +42,8 @@ static int ade7754_spi_write_reg_8(struct device *dev,
}
static int ade7754_spi_write_reg_16(struct device *dev,
- u8 reg_address,
- u16 value)
+ u8 reg_address,
+ u16 value)
{
int ret;
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -60,8 +60,8 @@ static int ade7754_spi_write_reg_16(struct device *dev,
}
static int ade7754_spi_read_reg_8(struct device *dev,
- u8 reg_address,
- u8 *val)
+ u8 reg_address,
+ u8 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7754_state *st = iio_priv(indio_dev);
@@ -70,7 +70,7 @@ static int ade7754_spi_read_reg_8(struct device *dev,
ret = spi_w8r8(st->us, ADE7754_READ_REG(reg_address));
if (ret < 0) {
dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
- reg_address);
+ reg_address);
return ret;
}
*val = ret;
@@ -79,8 +79,8 @@ static int ade7754_spi_read_reg_8(struct device *dev,
}
static int ade7754_spi_read_reg_16(struct device *dev,
- u8 reg_address,
- u16 *val)
+ u8 reg_address,
+ u16 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7754_state *st = iio_priv(indio_dev);
@@ -99,8 +99,8 @@ static int ade7754_spi_read_reg_16(struct device *dev,
}
static int ade7754_spi_read_reg_24(struct device *dev,
- u8 reg_address,
- u32 *val)
+ u8 reg_address,
+ u32 *val)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7754_state *st = iio_priv(indio_dev);
@@ -123,7 +123,7 @@ static int ade7754_spi_read_reg_24(struct device *dev,
ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
if (ret) {
dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
- reg_address);
+ reg_address);
goto error_ret;
}
*val = (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
@@ -134,8 +134,8 @@ error_ret:
}
static ssize_t ade7754_read_8bit(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+ struct device_attribute *attr,
+ char *buf)
{
int ret;
u8 val = 0;
@@ -149,8 +149,8 @@ static ssize_t ade7754_read_8bit(struct device *dev,
}
static ssize_t ade7754_read_16bit(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+ struct device_attribute *attr,
+ char *buf)
{
int ret;
u16 val = 0;
@@ -164,8 +164,8 @@ static ssize_t ade7754_read_16bit(struct device *dev,
}
static ssize_t ade7754_read_24bit(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+ struct device_attribute *attr,
+ char *buf)
{
int ret;
u32 val = 0;
@@ -179,9 +179,8 @@ static ssize_t ade7754_read_24bit(struct device *dev,
}
static ssize_t ade7754_write_8bit(struct device *dev,
- struct device_attribute *attr,
- const char *buf,
- size_t len)
+ struct device_attribute *attr,
+ const char *buf, size_t len)
{
struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
int ret;
@@ -197,9 +196,8 @@ error_ret:
}
static ssize_t ade7754_write_16bit(struct device *dev,
- struct device_attribute *attr,
- const char *buf,
- size_t len)
+ struct device_attribute *attr,
+ const char *buf, size_t len)
{
struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
int ret;
@@ -403,16 +401,14 @@ err_ret:
}
static ssize_t ade7754_read_frequency(struct device *dev,
- struct device_attribute *attr,
- char *buf)
+ struct device_attribute *attr,
+ char *buf)
{
int ret;
u8 t;
int sps;
- ret = ade7754_spi_read_reg_8(dev,
- ADE7754_WAVMODE,
- &t);
+ ret = ade7754_spi_read_reg_8(dev, ADE7754_WAVMODE, &t);
if (ret)
return ret;
@@ -423,9 +419,8 @@ static ssize_t ade7754_read_frequency(struct device *dev,
}
static ssize_t ade7754_write_frequency(struct device *dev,
- struct device_attribute *attr,
- const char *buf,
- size_t len)
+ struct device_attribute *attr,
+ const char *buf, size_t len)
{
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
struct ade7754_state *st = iio_priv(indio_dev);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: iio: meter: ade7754: Match alignment with open parenthesis
2016-09-19 11:36 [PATCH] staging: iio: meter: ade7754: Match alignment with open parenthesis Georgiana Rodica Chelu
@ 2016-09-19 11:41 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-19 11:41 UTC (permalink / raw)
To: Georgiana Rodica Chelu; +Cc: outreachy-kernel
On Mon, 19 Sep 2016, Georgiana Rodica Chelu wrote:
> This patch fixes the following checkpatch.pl check:
> CHECK: Alignment should match open parenthesis
In many of these cases you could reorganie the parameter list to better
use the horizontal space available.
Try to avoid using the work "fix" in your commit messages. It is better
to give an overview of what you have done in order to fix the problem.
julia
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
> ---
> drivers/staging/iio/meter/ade7754.c | 59 +++++++++++++++++--------------------
> 1 file changed, 27 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/iio/meter/ade7754.c b/drivers/staging/iio/meter/ade7754.c
> index c46bef64..4e93987 100644
> --- a/drivers/staging/iio/meter/ade7754.c
> +++ b/drivers/staging/iio/meter/ade7754.c
> @@ -24,8 +24,8 @@
> #include "ade7754.h"
>
> static int ade7754_spi_write_reg_8(struct device *dev,
> - u8 reg_address,
> - u8 val)
> + u8 reg_address,
> + u8 val)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -42,8 +42,8 @@ static int ade7754_spi_write_reg_8(struct device *dev,
> }
>
> static int ade7754_spi_write_reg_16(struct device *dev,
> - u8 reg_address,
> - u16 value)
> + u8 reg_address,
> + u16 value)
> {
> int ret;
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -60,8 +60,8 @@ static int ade7754_spi_write_reg_16(struct device *dev,
> }
>
> static int ade7754_spi_read_reg_8(struct device *dev,
> - u8 reg_address,
> - u8 *val)
> + u8 reg_address,
> + u8 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7754_state *st = iio_priv(indio_dev);
> @@ -70,7 +70,7 @@ static int ade7754_spi_read_reg_8(struct device *dev,
> ret = spi_w8r8(st->us, ADE7754_READ_REG(reg_address));
> if (ret < 0) {
> dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
> - reg_address);
> + reg_address);
> return ret;
> }
> *val = ret;
> @@ -79,8 +79,8 @@ static int ade7754_spi_read_reg_8(struct device *dev,
> }
>
> static int ade7754_spi_read_reg_16(struct device *dev,
> - u8 reg_address,
> - u16 *val)
> + u8 reg_address,
> + u16 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7754_state *st = iio_priv(indio_dev);
> @@ -99,8 +99,8 @@ static int ade7754_spi_read_reg_16(struct device *dev,
> }
>
> static int ade7754_spi_read_reg_24(struct device *dev,
> - u8 reg_address,
> - u32 *val)
> + u8 reg_address,
> + u32 *val)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7754_state *st = iio_priv(indio_dev);
> @@ -123,7 +123,7 @@ static int ade7754_spi_read_reg_24(struct device *dev,
> ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
> if (ret) {
> dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
> - reg_address);
> + reg_address);
> goto error_ret;
> }
> *val = (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3];
> @@ -134,8 +134,8 @@ error_ret:
> }
>
> static ssize_t ade7754_read_8bit(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u8 val = 0;
> @@ -149,8 +149,8 @@ static ssize_t ade7754_read_8bit(struct device *dev,
> }
>
> static ssize_t ade7754_read_16bit(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u16 val = 0;
> @@ -164,8 +164,8 @@ static ssize_t ade7754_read_16bit(struct device *dev,
> }
>
> static ssize_t ade7754_read_24bit(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u32 val = 0;
> @@ -179,9 +179,8 @@ static ssize_t ade7754_read_24bit(struct device *dev,
> }
>
> static ssize_t ade7754_write_8bit(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> {
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> int ret;
> @@ -197,9 +196,8 @@ error_ret:
> }
>
> static ssize_t ade7754_write_16bit(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> {
> struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> int ret;
> @@ -403,16 +401,14 @@ err_ret:
> }
>
> static ssize_t ade7754_read_frequency(struct device *dev,
> - struct device_attribute *attr,
> - char *buf)
> + struct device_attribute *attr,
> + char *buf)
> {
> int ret;
> u8 t;
> int sps;
>
> - ret = ade7754_spi_read_reg_8(dev,
> - ADE7754_WAVMODE,
> - &t);
> + ret = ade7754_spi_read_reg_8(dev, ADE7754_WAVMODE, &t);
> if (ret)
> return ret;
>
> @@ -423,9 +419,8 @@ static ssize_t ade7754_read_frequency(struct device *dev,
> }
>
> static ssize_t ade7754_write_frequency(struct device *dev,
> - struct device_attribute *attr,
> - const char *buf,
> - size_t len)
> + struct device_attribute *attr,
> + const char *buf, size_t len)
> {
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ade7754_state *st = iio_priv(indio_dev);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160919113624.GA10298%40fireworks.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-19 11:36 [PATCH] staging: iio: meter: ade7754: Match alignment with open parenthesis Georgiana Rodica Chelu
2016-09-19 11:41 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.