All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Benc <jbenc@redhat.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>,
	Josh Triplett <josh@joshtriplett.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ptp_clock: allow for it to be optional
Date: Mon, 19 Sep 2016 14:25:53 +0200	[thread overview]
Message-ID: <20160919142553.3fb682ba@griffin> (raw)
In-Reply-To: <1474257070-4255-2-git-send-email-nicolas.pitre@linaro.org>

On Sun, 18 Sep 2016 23:51:09 -0400, Nicolas Pitre wrote:
> And to make it possible for PTP to be configured out, the select statement
> in the Kconfig entry for those ethernet drivers is changed from selecting
> PTP_1588_CLOCK to PTP_1588_CLOCK_SELECTED whose purpose is to indicate the
> default Kconfig value for the PTP subsystem.

With this patch applied, the user is free to set a NIC driver as built
in and PTP_1588_CLOCK as a module, right? If so, that would lead to
non-functional PTP without any warning due to the use of IS_REACHABLE.
That doesn't sound right. Could easily cause hours of headache to
someone.

Or is this handled somehow?

Thanks,

 Jiri

  parent reply	other threads:[~2016-09-19 12:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19  3:51 [PATCH 0/2] make POSIX timers configurable Nicolas Pitre
2016-09-19  3:51 ` [PATCH 1/2] ptp_clock: allow for it to be optional Nicolas Pitre
2016-09-19 12:25   ` Eugenia Emantayev
2016-09-19 12:25   ` Jiri Benc [this message]
2016-09-19 14:10     ` Nicolas Pitre
2016-09-19 17:04       ` Jiri Benc
2016-09-19 17:31         ` Josh Triplett
2016-09-19 18:09           ` Nicolas Pitre
2016-09-19  3:51 ` [PATCH 2/2] posix-timers: make it configurable Nicolas Pitre
  -- strict thread matches above, loose matches on Subject: below --
2016-09-20 19:56 [PATCH v2 0/2] make POSIX timers optional Nicolas Pitre
2016-09-20 19:56 ` [PATCH 1/2] ptp_clock: allow for it to be optional Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160919142553.3fb682ba@griffin \
    --to=jbenc@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=richardcochran@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.