* [PATCH] staging: wlan-ng: fixed parenthesis alignment
@ 2016-09-19 19:58 Juliana R
2016-09-19 20:15 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Juliana R @ 2016-09-19 19:58 UTC (permalink / raw)
To: gregkh, outreachy-kernel
This patch aims to fix a checkpatch warning
caused by open parenthesis alignment.
Signed-off-by: Juliana R <juliana.orod@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index bed4672..f1d93b7 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -661,7 +661,7 @@ void prism2_connect_result(struct wlandevice *wlandev, u8 failed)
void prism2_disconnected(struct wlandevice *wlandev)
{
cfg80211_disconnected(wlandev->netdev, 0, NULL,
- 0, false, GFP_KERNEL);
+ 0, false, GFP_KERNEL);
}
void prism2_roamed(struct wlandevice *wlandev)
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: wlan-ng: fixed parenthesis alignment
2016-09-19 19:58 [PATCH] staging: wlan-ng: fixed parenthesis alignment Juliana R
@ 2016-09-19 20:15 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-19 20:15 UTC (permalink / raw)
To: Juliana R; +Cc: gregkh, outreachy-kernel
On Mon, 19 Sep 2016, Juliana R wrote:
> This patch aims to fix a checkpatch warning
> caused by open parenthesis alignment.
"This patch aims to fix" is not useful. We know it is a patch, and "aims
to fix" suggests that you have not succeeded in fixing the issue. It
would be better to say what you did, eg Move arguments to the right to
align them with the open parenthesis, as suggested by checkpatch.
> Signed-off-by: Juliana R <juliana.orod@gmail.com>
I guess there is more to your last name than R? You need to put your full
name.
Thanks for the patch :)
julia
> ---
> drivers/staging/wlan-ng/cfg80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index bed4672..f1d93b7 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -661,7 +661,7 @@ void prism2_connect_result(struct wlandevice *wlandev, u8 failed)
> void prism2_disconnected(struct wlandevice *wlandev)
> {
> cfg80211_disconnected(wlandev->netdev, 0, NULL,
> - 0, false, GFP_KERNEL);
> + 0, false, GFP_KERNEL);
> }
>
> void prism2_roamed(struct wlandevice *wlandev)
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160919195828.GA32755%40spock.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-19 19:58 [PATCH] staging: wlan-ng: fixed parenthesis alignment Juliana R
2016-09-19 20:15 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.