[PATCH v2] staging: wlan-ng: fixed alignment not matching

[PATCH v2] staging: wlan-ng: fixed alignment not matching

[Juliana R]

This patch fixes a checkpatch warning by
moving arguments to the right and aligning them
to their open parenthesis.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
---
Changes in v2:
   - Make the commit message clearer.
---
 drivers/staging/wlan-ng/cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 8c592be..bed4672 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -334,7 +334,7 @@ static int prism2_scan(struct wiphy *wiphy,
 		msg1.scantype.data = P80211ENUM_scantype_active;
 		msg1.ssid.data.len = request->ssids->ssid_len;
 		memcpy(msg1.ssid.data.data,
-			request->ssids->ssid, request->ssids->ssid_len);
+		       request->ssids->ssid, request->ssids->ssid_len);
 	} else {
 		msg1.scantype.data = 0;
 	}
-- 
2.9.3

Re: [Outreachy kernel] [PATCH v2] staging: wlan-ng: fixed alignment not matching

[Julia Lawall]

On Mon, 19 Sep 2016, Juliana R wrote:

> This patch fixes a checkpatch warning by
> moving arguments to the right and aligning them
> to their open parenthesis.

You can use more of the horizontal space.  Don't go over 80 characters,
but you don't have to cut it off half way either.

Use the imperative in your commit message as well.  Here the message could
start with "Move arguments to the right...".  See the Patch philosophy
page:

https://kernelnewbies.org/PatchPhilosophy

julia

>
> Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
> ---
> Changes in v2:
>    - Make the commit message clearer.
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 8c592be..bed4672 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -334,7 +334,7 @@ static int prism2_scan(struct wiphy *wiphy,
>  		msg1.scantype.data = P80211ENUM_scantype_active;
>  		msg1.ssid.data.len = request->ssids->ssid_len;
>  		memcpy(msg1.ssid.data.data,
> -			request->ssids->ssid, request->ssids->ssid_len);
> +		       request->ssids->ssid, request->ssids->ssid_len);
>  	} else {
>  		msg1.scantype.data = 0;
>  	}
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160919212441.GA19124%40spock.
> For more options, visit https://groups.google.com/d/optout.
>