From: Sergio Prado <sergio.prado@e-labworks.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org,
k.kozlowski@samsung.com, boris.brezillon@free-electrons.com,
richard@nod.at, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] mtd: s3c2410: add device tree support
Date: Mon, 19 Sep 2016 23:31:49 -0300 [thread overview]
Message-ID: <20160920023149.GC11294@n1> (raw)
In-Reply-To: <f8907616-0d6b-37ef-1419-f6aedf3ddbdc@samsung.com>
On Mon, Sep 19, 2016 at 12:44:07PM +0200, Sylwester Nawrocki wrote:
> On 09/17/2016 05:22 PM, Sergio Prado wrote:
> > +static int s3c24xx_nand_probe_dt(struct platform_device *pdev)
> > +{
> > + const struct s3c24XX_nand_devtype_data *devtype_data;
> > + struct s3c2410_platform_nand *pdata;
> > + struct s3c2410_nand_info *info = platform_get_drvdata(pdev);
> > + struct device_node *np = pdev->dev.of_node, *child;
> > + const struct of_device_id *of_id;
> > + struct s3c2410_nand_set *sets;
> > +
> > + of_id = of_match_device(s3c24xx_nand_dt_ids, &pdev->dev);
> > + if (!of_id)
> > + return 1;
> > +
> > + devtype_data = of_id->data;
>
> You could make it a bit simpler with of_device_get_match_data().
I wasn't aware of this interface. I'll use it. Thanks!
>
> --
> Thanks,
> Sylwester
--
Sergio Prado
Embedded Labworks
Office: +55 11 2628-3461
Mobile: +55 11 97123-3420
WARNING: multiple messages have this Message-ID (diff)
From: Sergio Prado <sergio.prado-1e4yhPs3/ABSwrhanM7KvQ@public.gmane.org>
To: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
richard-/L3Ra7n9ekc@public.gmane.org,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mtd: s3c2410: add device tree support
Date: Mon, 19 Sep 2016 23:31:49 -0300 [thread overview]
Message-ID: <20160920023149.GC11294@n1> (raw)
In-Reply-To: <f8907616-0d6b-37ef-1419-f6aedf3ddbdc-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Mon, Sep 19, 2016 at 12:44:07PM +0200, Sylwester Nawrocki wrote:
> On 09/17/2016 05:22 PM, Sergio Prado wrote:
> > +static int s3c24xx_nand_probe_dt(struct platform_device *pdev)
> > +{
> > + const struct s3c24XX_nand_devtype_data *devtype_data;
> > + struct s3c2410_platform_nand *pdata;
> > + struct s3c2410_nand_info *info = platform_get_drvdata(pdev);
> > + struct device_node *np = pdev->dev.of_node, *child;
> > + const struct of_device_id *of_id;
> > + struct s3c2410_nand_set *sets;
> > +
> > + of_id = of_match_device(s3c24xx_nand_dt_ids, &pdev->dev);
> > + if (!of_id)
> > + return 1;
> > +
> > + devtype_data = of_id->data;
>
> You could make it a bit simpler with of_device_get_match_data().
I wasn't aware of this interface. I'll use it. Thanks!
>
> --
> Thanks,
> Sylwester
--
Sergio Prado
Embedded Labworks
Office: +55 11 2628-3461
Mobile: +55 11 97123-3420
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: sergio.prado@e-labworks.com (Sergio Prado)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: s3c2410: add device tree support
Date: Mon, 19 Sep 2016 23:31:49 -0300 [thread overview]
Message-ID: <20160920023149.GC11294@n1> (raw)
In-Reply-To: <f8907616-0d6b-37ef-1419-f6aedf3ddbdc@samsung.com>
On Mon, Sep 19, 2016 at 12:44:07PM +0200, Sylwester Nawrocki wrote:
> On 09/17/2016 05:22 PM, Sergio Prado wrote:
> > +static int s3c24xx_nand_probe_dt(struct platform_device *pdev)
> > +{
> > + const struct s3c24XX_nand_devtype_data *devtype_data;
> > + struct s3c2410_platform_nand *pdata;
> > + struct s3c2410_nand_info *info = platform_get_drvdata(pdev);
> > + struct device_node *np = pdev->dev.of_node, *child;
> > + const struct of_device_id *of_id;
> > + struct s3c2410_nand_set *sets;
> > +
> > + of_id = of_match_device(s3c24xx_nand_dt_ids, &pdev->dev);
> > + if (!of_id)
> > + return 1;
> > +
> > + devtype_data = of_id->data;
>
> You could make it a bit simpler with of_device_get_match_data().
I wasn't aware of this interface. I'll use it. Thanks!
>
> --
> Thanks,
> Sylwester
--
Sergio Prado
Embedded Labworks
Office: +55 11 2628-3461
Mobile: +55 11 97123-3420
next prev parent reply other threads:[~2016-09-20 2:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160917152404eucas1p2ca0ebfe59dd762f5cdd611a9dd3cd1a5@eucas1p2.samsung.com>
2016-09-17 15:22 ` [PATCH] mtd: s3c2410: add device tree support Sergio Prado
2016-09-17 15:22 ` Sergio Prado
2016-09-17 15:22 ` Sergio Prado
2016-09-17 17:31 ` Boris Brezillon
2016-09-17 17:31 ` Boris Brezillon
2016-09-20 2:08 ` Sergio Prado
2016-09-20 2:08 ` Sergio Prado
2016-09-25 17:42 ` Sergio Prado
2016-09-25 17:42 ` Sergio Prado
2016-09-25 18:05 ` Boris Brezillon
2016-09-25 18:05 ` Boris Brezillon
2016-09-25 18:05 ` Boris Brezillon
2016-09-19 9:11 ` Mark Rutland
2016-09-19 9:11 ` Mark Rutland
2016-09-20 2:24 ` Sergio Prado
2016-09-20 2:24 ` Sergio Prado
2016-09-20 2:24 ` Sergio Prado
2016-09-19 10:44 ` Sylwester Nawrocki
2016-09-19 10:44 ` Sylwester Nawrocki
2016-09-20 2:31 ` Sergio Prado [this message]
2016-09-20 2:31 ` Sergio Prado
2016-09-20 2:31 ` Sergio Prado
2016-09-23 17:44 ` Rob Herring
2016-09-23 17:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920023149.GC11294@n1 \
--to=sergio.prado@e-labworks.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.