From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: James Simmons <jsimmons@infradead.org>,
devel@driverdev.osuosl.org, James Simmons <uja.ornl@yahoo.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md
Date: Tue, 20 Sep 2016 11:52:19 +0300 [thread overview]
Message-ID: <20160920085134.GH13620@mwanda> (raw)
In-Reply-To: <20160920064702.GB8527@kroah.com>
On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > was done when porting to the upstream client.
>
> How did our build testing not catch this? What needs these exports? Is
> it any in-kernel code?
>
> confused,
It did catch it... James, every patch has to be buildable (bisectable)
so the original patch is never going to be merged.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: James Simmons <jsimmons@infradead.org>,
devel@driverdev.osuosl.org, James Simmons <uja.ornl@yahoo.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Drokin <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md
Date: Tue, 20 Sep 2016 11:52:19 +0300 [thread overview]
Message-ID: <20160920085134.GH13620@mwanda> (raw)
In-Reply-To: <20160920064702.GB8527@kroah.com>
On Tue, Sep 20, 2016 at 08:47:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Sep 19, 2016 at 01:27:05PM -0400, James Simmons wrote:
> > Being over zealous in removing unused EXPORT_SYMBOLs two functions
> > lustre_swab_[lmv|lov]_mds_md exports were removed. They need to be
> > exported so this patch restores those EXPORT_SYMBOLS. Same mistake
> > was done when porting to the upstream client.
>
> How did our build testing not catch this? What needs these exports? Is
> it any in-kernel code?
>
> confused,
It did catch it... James, every patch has to be buildable (bisectable)
so the original patch is never going to be merged.
regards,
dan carpenter
next prev parent reply other threads:[~2016-09-20 8:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 17:27 [lustre-devel] [PATCH] staging: lustre: ptlrpc: re-export lustre_swab_[lmv|lov]_mds_md James Simmons
2016-09-19 17:27 ` James Simmons
2016-09-20 6:47 ` [lustre-devel] " Greg Kroah-Hartman
2016-09-20 6:47 ` Greg Kroah-Hartman
2016-09-20 8:52 ` Dan Carpenter [this message]
2016-09-20 8:52 ` Dan Carpenter
2016-09-20 11:05 ` [lustre-devel] " Greg Kroah-Hartman
2016-09-20 11:05 ` Greg Kroah-Hartman
2016-09-20 11:16 ` [lustre-devel] " Dan Carpenter
2016-09-20 11:16 ` Dan Carpenter
2016-09-20 11:39 ` [lustre-devel] " Greg Kroah-Hartman
2016-09-20 11:39 ` Greg Kroah-Hartman
2016-09-20 15:32 ` [lustre-devel] " James Simmons
2016-09-20 15:32 ` James Simmons
2016-09-20 15:18 ` James Simmons
2016-09-20 15:18 ` James Simmons
2016-09-20 11:18 ` [lustre-devel] " Greg Kroah-Hartman
2016-09-20 11:18 ` Greg Kroah-Hartman
2016-09-20 15:52 ` [lustre-devel] " James Simmons
2016-09-20 15:52 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920085134.GH13620@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=uja.ornl@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.