All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: Migrate to Kconfig
Date: Tue, 20 Sep 2016 12:53:02 +0200	[thread overview]
Message-ID: <20160920125302.459b8b08@amdc2363> (raw)
In-Reply-To: <20160919181902.GG29602@bill-the-cat>

Hi Tom,

> On Mon, Sep 19, 2016 at 01:31:30PM -0400, Tom Rini wrote:
> 
> > Introduce a hidden USB_FUNCTION_DFU Kconfig option and select it for
> > CMD_DFU (as we must have the DFU command enabled to do anything
> > DFU). Make all of the entries in drivers/dfu/Kconfig depend on
> > CMD_DFU and add options for all of the back end choices that DFU
> > can make use of.
> [snip]
> > +config DFU_MMC
> > +	bool "MMC back end for DFU"
> > +	help
> > +	  This option enables using DFU to read and write to MMC
> > based storage.
> 
> Adding:
> 	  If working with an underlying filesystem rather than raw
> 	  storage you will still need to enable the appropriate write
> 	  commands.
> 
> As in doing local testing of stuff that drove me to scratch this itch
> I noticed that CMD_EXT4_WRITE is not set on sunxi.  But I don't think
> we should force fat+ext4 write to be enabled simply because DFU_MMC
> is set. I should however follow up with adding default y if DFU_MMC to
> CMD_EXT4_WRITE and migrate FAT_WRITE to Kconfig as well.
> 

+1

Thanks for investigation.

(It comes to me that inevitably	it is the highest time to move
DFU/THor/UMS and underlying USB layers to DM and Kconfig).



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2016-09-20 10:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160919173112eucas1p2d7d9a29201aa72349ab8b01f031109fc@eucas1p2.samsung.com>
2016-09-19 17:31 ` [U-Boot] [PATCH] dfu: Migrate to Kconfig Tom Rini
2016-09-19 18:19   ` Tom Rini
2016-09-20 10:53     ` Lukasz Majewski [this message]
2016-09-20 10:53   ` Lukasz Majewski
2016-09-27 21:34   ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920125302.459b8b08@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.