All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: Migrate to Kconfig
Date: Tue, 20 Sep 2016 12:53:56 +0200	[thread overview]
Message-ID: <20160920125356.6ed1ccfb@amdc2363> (raw)
In-Reply-To: <1474306290-20203-1-git-send-email-trini@konsulko.com>

Hi Tom,

> Introduce a hidden USB_FUNCTION_DFU Kconfig option and select it for
> CMD_DFU (as we must have the DFU command enabled to do anything DFU).
> Make all of the entries in drivers/dfu/Kconfig depend on CMD_DFU and
> add options for all of the back end choices that DFU can make use of.
> 
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Once ack'd I'll run moveconfig.py to migrate everyone over and check
> for size changes.  This will also depend on the patch I sent to
> change the malloc pool size on TI parts as we otherwise will now
> expose the bug about DFU_MMC being unset.
> ---
>  cmd/Kconfig         |  1 +
>  drivers/dfu/Kconfig | 28 ++++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index d28da54ed659..26720b6e1f0d 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -404,6 +404,7 @@ config CMD_USB
>  
>  config CMD_DFU
>  	bool "dfu"
> +	select USB_FUNCTION_DFU
>  	help
>  	  Enables the command "dfu" which is used to have U-Boot
> create a DFU class device via USB.
> diff --git a/drivers/dfu/Kconfig b/drivers/dfu/Kconfig
> index 6b92064f0b52..56a98f5273ce 100644
> --- a/drivers/dfu/Kconfig
> +++ b/drivers/dfu/Kconfig
> @@ -1,5 +1,9 @@
>  menu "DFU support"
>  
> +config USB_FUNCTION_DFU
> +	bool
> +
> +if CMD_DFU
>  config DFU_TFTP
>  	bool "DFU via TFTP"
>  	help
> @@ -7,4 +11,28 @@ config DFU_TFTP
>  	  sent via TFTP boot.
>  
>  	  Detailed description of this feature can be found
> at ./doc/README.dfutftp +
> +config DFU_MMC
> +	bool "MMC back end for DFU"
> +	help
> +	  This option enables using DFU to read and write to MMC
> based storage. +
> +config DFU_NAND
> +	bool "NAND back end for DFU"
> +	help
> +	  This option enables using DFU to read and write to NAND
> based
> +	  storage.
> +
> +config DFU_RAM
> +	bool "RAM back end for DFU"
> +	help
> +	  This option enables using DFU to read and write RAM on the
> target. +
> +config DFU_SF
> +	bool "SPI flash back end for DFU"
> +	help
> +	  This option enables using DFU to read and write to SPI
> flash based
> +	  storage.
> +
> +endif
>  endmenu

Acked-by: Lukasz Majewski <l.majewski@samsung.com>

Tom, thanks for the patch.

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  parent reply	other threads:[~2016-09-20 10:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160919173112eucas1p2d7d9a29201aa72349ab8b01f031109fc@eucas1p2.samsung.com>
2016-09-19 17:31 ` [U-Boot] [PATCH] dfu: Migrate to Kconfig Tom Rini
2016-09-19 18:19   ` Tom Rini
2016-09-20 10:53     ` Lukasz Majewski
2016-09-20 10:53   ` Lukasz Majewski [this message]
2016-09-27 21:34   ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160920125356.6ed1ccfb@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.