From: Shawn Guo <shawnguo@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Peter Hurley <peter@hurleysoftware.com>,
Jason Liu <jason.liu@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Timur Tabi <timur@codeaurora.org>,
xie.baoyou@zte.com.cn,
Russell King - ARM Linux <linux@armlinux.org.uk>,
linux-serial@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
Jun Nie <jun.nie@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: amba-pl011: uart_amba_port is not available with earlycon function
Date: Tue, 20 Sep 2016 21:05:04 +0800 [thread overview]
Message-ID: <20160920130504.GF3744@tiger> (raw)
In-Reply-To: <1474092878-30034-1-git-send-email-shawn.guo@linaro.org>
On Sat, Sep 17, 2016 at 02:14:38PM +0800, Shawn Guo wrote:
> Commit 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE
> device") changes earlycon function pl011_putc() to use a pointer to
> uart_amba_port. This causes a regression when earlycon is enabled,
> because uart_amba_port is not available yet at earlycon time. Let's
> revert the change on pl011_putc() to fix the regression.
>
> The earlycon support for ZTE device can probably be added later by
> declaring a new earlycon setup function with a vendor specific
> compatible.
>
> Reported-by: Sudeep Holla <sudeep.holla@arm.com>
> Fixes: 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE device")
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Hi Sudeep,
Can you please confirm if the patch fixes your problem, so that Greg
knows whether it should be applied? Thanks.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: amba-pl011: uart_amba_port is not available with earlycon function
Date: Tue, 20 Sep 2016 21:05:04 +0800 [thread overview]
Message-ID: <20160920130504.GF3744@tiger> (raw)
In-Reply-To: <1474092878-30034-1-git-send-email-shawn.guo@linaro.org>
On Sat, Sep 17, 2016 at 02:14:38PM +0800, Shawn Guo wrote:
> Commit 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE
> device") changes earlycon function pl011_putc() to use a pointer to
> uart_amba_port. This causes a regression when earlycon is enabled,
> because uart_amba_port is not available yet at earlycon time. Let's
> revert the change on pl011_putc() to fix the regression.
>
> The earlycon support for ZTE device can probably be added later by
> declaring a new earlycon setup function with a vendor specific
> compatible.
>
> Reported-by: Sudeep Holla <sudeep.holla@arm.com>
> Fixes: 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE device")
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Hi Sudeep,
Can you please confirm if the patch fixes your problem, so that Greg
knows whether it should be applied? Thanks.
Shawn
next prev parent reply other threads:[~2016-09-20 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 6:14 [PATCH] tty: amba-pl011: uart_amba_port is not available with earlycon function Shawn Guo
2016-09-17 6:14 ` Shawn Guo
2016-09-20 13:05 ` Shawn Guo [this message]
2016-09-20 13:05 ` Shawn Guo
2016-09-20 13:15 ` Sudeep Holla
2016-09-20 13:15 ` Sudeep Holla
2016-09-20 13:23 ` Shawn Guo
2016-09-20 13:23 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920130504.GF3744@tiger \
--to=shawnguo@kernel.org \
--cc=andre.przywara@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason.liu@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter@hurleysoftware.com \
--cc=sudeep.holla@arm.com \
--cc=timur@codeaurora.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.