From: Greg KH <gregkh@linuxfoundation.org>
To: Moshe Green <mgmoshes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type
Date: Fri, 23 Sep 2016 12:13:52 +0000 [thread overview]
Message-ID: <20160923121352.GA3556@kroah.com> (raw)
In-Reply-To: <9a9ab953f0c55df0ffe75a7a3c35ba6dc9e2f742.1474568117.git.mgmoshes@gmail.com>
On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote:
> Rename CamelCased function getChipType to get_chip_type.
> This issue was found by checkpatch.pl
As this is a global function, can you rename it to something like
"sm750_get_chip_type()"? Having a driver-specific function called
get_chip_type() is not good.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Moshe Green <mgmoshes@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename getChipType to get_chip_type
Date: Fri, 23 Sep 2016 14:13:52 +0200 [thread overview]
Message-ID: <20160923121352.GA3556@kroah.com> (raw)
In-Reply-To: <9a9ab953f0c55df0ffe75a7a3c35ba6dc9e2f742.1474568117.git.mgmoshes@gmail.com>
On Thu, Sep 22, 2016 at 09:15:45PM +0300, Moshe Green wrote:
> Rename CamelCased function getChipType to get_chip_type.
> This issue was found by checkpatch.pl
As this is a global function, can you rename it to something like
"sm750_get_chip_type()"? Having a driver-specific function called
get_chip_type() is not good.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-23 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 18:15 [PATCH] staging: sm750fb: rename getChipType to get_chip_type Moshe Green
2016-09-22 18:15 ` Moshe Green
2016-09-23 12:13 ` Greg KH [this message]
2016-09-23 12:13 ` Greg KH
2016-09-24 21:09 ` Moshe Green
2016-09-24 21:09 ` Moshe Green
2016-09-25 19:58 ` [PATCH] staging: sm750fb: rename getChipType to sm750_get_chip_type Moshe Green
2016-09-25 19:58 ` Moshe Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923121352.GA3556@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgmoshes@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.