From: Greg KH <gregkh@linuxfoundation.org>
To: Yannis Damigos <giannis.damigos@gmail.com>
Cc: devel@driverdev.osuosl.org, arve@android.com,
riandrews@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues
Date: Fri, 23 Sep 2016 17:06:42 +0200 [thread overview]
Message-ID: <20160923150642.GA13933@kroah.com> (raw)
In-Reply-To: <CAG5jFBp+JROg5g1Ece=Am79FqtapgFsXOFMLj8n7Vz6VOPXMrw@mail.gmail.com>
On Fri, Sep 23, 2016 at 04:26:28PM +0300, Yannis Damigos wrote:
> On Fri, Sep 23, 2016 at 3:17 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.damigos@gmail.com wrote:
> >> From: Yannis Damigos <giannis.damigos@gmail.com>
> >>
> >> This patch fixes the following blank line issues:
> >>
> >> CHECK: Please don't use multiple blank lines
> >> +
> >> +
> >
> > What does that mean with the + + lines?
> >
> >>
> >> CHECK: Please use a blank line after function/struct/union/enum
> >> declarations
> >> +}
> >> +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup);
> >
> > Linewrap :(
> >
> If the line is not wrapped, I get the following warning:
> Possible unwrapped commit description (prefer a maximum 75 chars per line)
>
> Should I ignore it?
Don't you think it makes sense to do so? :)
next prev parent reply other threads:[~2016-09-23 15:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 17:55 [PATCH] staging:android:io: Fix multiple styling issues Yannis Damigos
2016-09-22 18:22 ` Markus Böhme
2016-09-23 8:05 ` [PATCHv2 1/5] staging:android:ion: Fix comparison with NULL giannis.damigos
2016-09-23 8:05 ` [PATCHv2 2/5] staging:android:ion: Fix whitespace issues giannis.damigos
2016-09-23 12:17 ` Greg KH
2016-09-23 8:05 ` [PATCHv2 3/5] staging:android:ion: Fix blank line issues giannis.damigos
2016-09-23 12:17 ` Greg KH
2016-09-23 13:26 ` Yannis Damigos
2016-09-23 15:06 ` Greg KH [this message]
2016-09-23 8:05 ` [PATCHv2 4/5] staging:android:ion: Fix switch case indentation giannis.damigos
2016-09-23 8:05 ` [PATCHv2 5/5] staging:android:ion: Fix void function return giannis.damigos
2016-09-23 8:44 ` Greg KH
2016-09-23 9:50 ` [PATCHv3 5/5] staging:android:ion: Remove empty release function Yannis Damigos
2016-09-23 12:06 ` Greg KH
2016-09-23 13:50 ` Yannis Damigos
2016-09-26 10:11 ` Yannis Damigos
2016-09-26 10:24 ` Greg KH
2016-09-26 10:30 ` Yannis Damigos
2016-09-23 12:18 ` Greg KH
2016-09-27 7:38 ` [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Yannis Damigos
2016-09-27 7:38 ` [PATCHv4 2/4] staging:android:ion: Fix alignment issues Yannis Damigos
2016-09-27 7:38 ` [PATCHv4 3/4] staging:android:ion: Fix blank line issues Yannis Damigos
2016-09-27 7:38 ` [PATCHv4 4/4] staging:android:ion: Fix whitespace issue Yannis Damigos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923150642.GA13933@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=giannis.damigos@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.