[PATCH v2] staging: ks7010: ks_wlan_net: Remove unnecessary variable used to store return value

[PATCH v2] staging: ks7010: ks_wlan_net: Remove unnecessary variable used to store return value

[Georgiana Rodica Chelu]

Remove unneeded code in order to make clear
that the function returns 0(success) in all cases.

Done using returnvar.cocci script.

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
Changes in v2:
        - Give a better reason for the modification

 drivers/staging/ks7010/ks_wlan_net.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
index f1cd90e..d13a06b 100644
--- a/drivers/staging/ks7010/ks_wlan_net.c
+++ b/drivers/staging/ks7010/ks_wlan_net.c
@@ -3507,12 +3507,11 @@ int ks_wlan_net_stop(struct net_device *dev)
 {
 	struct ks_wlan_private *priv = netdev_priv(dev);
 
-	int ret = 0;
 	priv->device_open_status = 0;
 	del_timer_sync(&update_phyinfo_timer);
 
 	if (netif_running(dev))
 		netif_stop_queue(dev);
 
-	return ret;
+	return 0;
 }
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v2] staging: ks7010: ks_wlan_net: Remove unnecessary variable used to store return value

[Julia Lawall]

On Fri, 23 Sep 2016, Georgiana Rodica Chelu wrote:

> Remove unneeded code in order to make clear
> that the function returns 0(success) in all cases.
>
> Done using returnvar.cocci script.
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> Changes in v2:
>         - Give a better reason for the modification
>
>  drivers/staging/ks7010/ks_wlan_net.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
> index f1cd90e..d13a06b 100644
> --- a/drivers/staging/ks7010/ks_wlan_net.c
> +++ b/drivers/staging/ks7010/ks_wlan_net.c
> @@ -3507,12 +3507,11 @@ int ks_wlan_net_stop(struct net_device *dev)
>  {
>  	struct ks_wlan_private *priv = netdev_priv(dev);
>
> -	int ret = 0;
>  	priv->device_open_status = 0;
>  	del_timer_sync(&update_phyinfo_timer);
>
>  	if (netif_running(dev))
>  		netif_stop_queue(dev);
>
> -	return ret;
> +	return 0;
>  }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160923194525.GA7252%40fireworks.
> For more options, visit https://groups.google.com/d/optout.
>