From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, famz@redhat.com
Subject: Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features
Date: Sun, 25 Sep 2016 03:49:13 +0300 [thread overview]
Message-ID: <20160925034836-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <efd2bb58-a1d9-48b6-26da-2bec98bab3cf@redhat.com>
On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote:
>
>
> On 24/09/2016 00:05, Michael S. Tsirkin wrote:
> >> e events...
> >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU...
> >> > ERROR: struct MemoryRegionIOMMUOps should normally be const
> >> > #1527: FILE: hw/i386/amd_iommu.h:280:
> >> > + MemoryRegionIOMMUOps iommu_ops;
> >
> > False positive.
>
> Not quite, there's no reason for the ops to be inside AMDVIState rather
> than a (static) global.
>
> Paolo
I guess but it's a logic refactoring, not merely a style one.
I feel we can do it on top, tool shouldn't require this.
next prev parent reply other threads:[~2016-09-25 0:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 19:57 [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 01/19] tests: add /vhost-user/connect-fail test Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 02/19] tests: add a simple /vhost-user/multiqueue test Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 03/19] tests: add /vhost-user/flags-mismatch test Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 04/19] virtio: add check for descriptor's mapped address Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 05/19] pc: clean up COMPAT macro chaining Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 06/19] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 07/19] virtio: fix stray tab character Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 08/19] virtio: stop virtqueue processing if device is broken Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 09/19] virtio: migrate vdev->broken flag Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 10/19] virtio: handle virtqueue_map_desc() errors Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 11/19] virtio: handle virtqueue_get_avail_bytes() errors Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 12/19] virtio: use unsigned int for virtqueue_get_avail_bytes() index Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 13/19] virtio: handle virtqueue_read_next_desc() errors Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 14/19] virtio: handle virtqueue_num_heads() errors Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 15/19] virtio: handle virtqueue_get_head() errors Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 16/19] hw/pci: Prepare for AMD IOMMU Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 17/19] hw/i386/trace-events: Add AMD IOMMU trace events Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 18/19] hw/i386: Introduce AMD IOMMU Michael S. Tsirkin
2016-09-23 19:57 ` [Qemu-devel] [PULL 19/19] hw/i386: AMD IOMMU IVRS table Michael S. Tsirkin
2016-09-23 20:35 ` [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features no-reply
2016-09-23 22:05 ` Michael S. Tsirkin
2016-09-23 20:35 ` no-reply
2016-09-23 22:05 ` Michael S. Tsirkin
2016-09-24 16:10 ` Paolo Bonzini
2016-09-25 0:49 ` Michael S. Tsirkin [this message]
2016-09-26 7:15 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925034836-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.