All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Vishwanath Pai <vpai@akamai.com>
Cc: Jan Engelhardt <jengelh@inai.de>,
	kaber@trash.net, kadlec@blackhole.kfki.hu, johunt@akamai.com,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org, pai.vishwain@gmail.com
Subject: Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates
Date: Sun, 25 Sep 2016 13:35:01 +0200	[thread overview]
Message-ID: <20160925113501.GD8331@salvia> (raw)
In-Reply-To: <57E42571.1060502@akamai.com>

On Thu, Sep 22, 2016 at 02:39:45PM -0400, Vishwanath Pai wrote:
> Thanks for pointing this out, I will reorder the fields to:
> 
> struct hashlimit_cfg2 {
> 	__u64 avg;    /* Average secs between packets * scale */
> 	__u64 burst;
> 	__u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */
> 
> This should fix the hole and avoid padding.

I have manually mangled this here, and applied, to get this change in
this in merge window.

I also have to revert the rename of XT_HASHLIMIT_SCALE to
XT_HASHLIMIT_SCALE_v1. This is exposed through uapi, this change would
break userspace.

Please, follow up in case of any fallout, thanks.

  reply	other threads:[~2016-09-25 11:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 16:43 [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates Vishwanath Pai
2016-09-22 16:53 ` Jan Engelhardt
2016-09-22 18:39   ` Vishwanath Pai
2016-09-25 11:35     ` Pablo Neira Ayuso [this message]
2016-09-25 12:58       ` Pablo Neira Ayuso
2016-09-27  4:15 ` Liping Zhang
2016-09-27  7:35   ` Vishwanath Pai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160925113501.GD8331@salvia \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=jengelh@inai.de \
    --cc=johunt@akamai.com \
    --cc=kaber@trash.net \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pai.vishwain@gmail.com \
    --cc=vpai@akamai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.