Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

[Vishwanath Pai <vpai@akamai.com>]

Thanks for pointing this out, I will reorder the fields to:

struct hashlimit_cfg2 {
	__u64 avg;    /* Average secs between packets * scale */
	__u64 burst;
	__u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */

This should fix the hole and avoid padding.

-Vishwanath

On 09/22/2016 12:53 PM, Jan Engelhardt wrote:
> On Thursday 2016-09-22 18:43, Vishwanath Pai wrote:
>> >+struct hashlimit_cfg2 {
>> >+	__u32 mode;	  /* bitmask of XT_HASHLIMIT_HASH_* */
>> >+	__u64 avg;    /* Average secs between packets * scale */
>> >+	__u64 burst;  /* Period multiplier for upper limit. */
> This would have different sizes between i386 and x86_64,
> necessiting additional compat functions. It should be padded
> or reordered instead.
>