From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
xie.baoyou@zte.com.cn, tang.qiang007@zte.com.cn,
han.fei@zte.com.cn
Subject: Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration
Date: Mon, 26 Sep 2016 01:29:41 +0200 [thread overview]
Message-ID: <201609260129.41684.arnd@arndb.de> (raw)
In-Reply-To: <CA+DQWkxQL0-3UFC7RTuBc2NQ1vwMScj9GLRwD62_yNg3pt1yNw@mail.gmail.com>
On Sunday 25 September 2016, Baoyou Xie wrote:
> On 24 September 2016 at 16:30, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > This can't be right for two reasons:
> >
> > - the suspend_test_wake_cause_interrupt_is_mine function again
> > is only used in the file it is defined in
> >
>
> but, it is declared as weak, so other modules can implement it.
In theory that is correct, but doing that would be very unusual
and bad style. As nobody does this at the moment, and the driver is for
obsolete hardware, just remove it now, and if we ever need want to
override it, that should be done using a runtime callback handler
or something completely different.
Arnd
next prev parent reply other threads:[~2016-09-25 23:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 5:34 [PATCH 1/2] mfd: ab8500-debugfs: add function declaration Baoyou Xie
2016-09-24 8:30 ` Arnd Bergmann
[not found] ` <CA+DQWkxQL0-3UFC7RTuBc2NQ1vwMScj9GLRwD62_yNg3pt1yNw@mail.gmail.com>
2016-09-25 23:29 ` Arnd Bergmann [this message]
2016-09-27 18:49 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609260129.41684.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=han.fei@zte.com.cn \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tang.qiang007@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.