From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Adit Ranadive <aditr@vmware.com>
Cc: Leon Romanovsky <leon@kernel.org>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
pv-drivers@vmware.com, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, jhansen@vmware.com,
asarwade@vmware.com, georgezhang@vmware.com, bryantan@vmware.com
Subject: Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver
Date: Mon, 26 Sep 2016 15:07:24 -0600 [thread overview]
Message-ID: <20160926210724.GA16413@obsidianresearch.com> (raw)
In-Reply-To: <b4e0acd9-e1a2-f6ac-0afa-c0fd62dd62f0@vmware.com>
On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote:
> Wouldnt they be some overlap between the user-space and kernel driver? Or is
> it expected that the common structures (even device specific ones) be moved to
> the ABI file?
Yes, even device specific structures must be in the abi file. Anything
that is used with copy_to_user/copy_from_user/etc.
> For the mlx4 driver I see that the structures in include/linux/mlx4/qp.h
> and in libmlx4/src/wqe.h are similar.
We are trying to clean exactly that sort of stuff up, please try not
to add more.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver
Date: Mon, 26 Sep 2016 15:07:24 -0600 [thread overview]
Message-ID: <20160926210724.GA16413@obsidianresearch.com> (raw)
In-Reply-To: <b4e0acd9-e1a2-f6ac-0afa-c0fd62dd62f0-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote:
> Wouldnt they be some overlap between the user-space and kernel driver? Or is
> it expected that the common structures (even device specific ones) be moved to
> the ABI file?
Yes, even device specific structures must be in the abi file. Anything
that is used with copy_to_user/copy_from_user/etc.
> For the mlx4 driver I see that the structures in include/linux/mlx4/qp.h
> and in libmlx4/src/wqe.h are similar.
We are trying to clean exactly that sort of stuff up, please try not
to add more.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-26 21:07 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 23:21 [PATCH v5 00/16] Add Paravirtual RDMA Driver Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 01/16] vmxnet3: Move PCI Id to pci_ids.h Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 02/16] IB/pvrdma: Add user-level shared functions Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-25 7:26 ` Leon Romanovsky
2016-09-25 7:26 ` Leon Romanovsky
2016-09-25 12:29 ` Leon Romanovsky
2016-09-26 4:22 ` Adit Ranadive
2016-09-26 4:22 ` Adit Ranadive
2016-09-26 4:22 ` Adit Ranadive
2016-09-26 6:13 ` Leon Romanovsky
2016-09-26 17:33 ` Adit Ranadive
2016-09-26 17:33 ` Adit Ranadive
2016-09-26 17:33 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 03/16] IB/pvrdma: Add virtual device RDMA structures Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 04/16] IB/pvrdma: Add the paravirtual RDMA device specification Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 05/16] IB/pvrdma: Add functions for Verbs support Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 06/16] IB/pvrdma: Add paravirtual rdma device Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 07/16] IB/pvrdma: Add helper functions Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 08/16] IB/pvrdma: Add device command support Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-26 7:16 ` Yuval Shaia
2016-09-26 7:16 ` Yuval Shaia
2016-09-26 18:06 ` Adit Ranadive
2016-09-26 18:06 ` Adit Ranadive
2016-09-26 18:06 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 09/16] IB/pvrdma: Add support for Completion Queues Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 10/16] IB/pvrdma: Add UAR support Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 11/16] IB/pvrdma: Add support for memory regions Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 12/16] IB/pvrdma: Add Queue Pair support Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 13/16] IB/pvrdma: Add the main driver module for PVRDMA Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-25 7:57 ` Leon Romanovsky
2016-09-25 7:57 ` Leon Romanovsky
2016-09-26 5:10 ` Adit Ranadive
2016-09-26 5:10 ` Adit Ranadive
2016-09-26 6:03 ` Leon Romanovsky
2016-09-26 6:03 ` Leon Romanovsky
2016-09-26 7:27 ` Yuval Shaia
2016-09-26 7:27 ` Yuval Shaia
2016-09-26 18:15 ` Adit Ranadive
2016-09-26 18:15 ` Adit Ranadive
2016-09-27 9:21 ` David Laight
2016-09-27 9:21 ` David Laight
2016-09-27 18:50 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 14/16] IB/pvrdma: Add Kconfig and Makefile Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 15/16] IB: Add PVRDMA driver Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-24 23:21 ` [PATCH v5 16/16] MAINTAINERS: Update for " Adit Ranadive
2016-09-24 23:21 ` Adit Ranadive
2016-09-25 7:30 ` Leon Romanovsky
2016-09-26 5:22 ` Adit Ranadive
2016-09-26 5:22 ` Adit Ranadive
2016-09-26 5:22 ` Adit Ranadive
2016-09-26 5:56 ` Leon Romanovsky
2016-09-25 7:03 ` [PATCH v5 00/16] Add Paravirtual RDMA Driver Leon Romanovsky
2016-09-26 5:25 ` Adit Ranadive
2016-09-26 5:25 ` Adit Ranadive
2016-09-26 5:57 ` Leon Romanovsky
2016-09-26 16:51 ` Jason Gunthorpe
2016-09-26 16:51 ` Jason Gunthorpe
2016-09-26 20:40 ` Adit Ranadive
2016-09-26 20:40 ` Adit Ranadive
2016-09-26 21:07 ` Jason Gunthorpe [this message]
2016-09-26 21:07 ` Jason Gunthorpe
2016-09-26 21:16 ` Adit Ranadive
2016-09-26 21:16 ` Adit Ranadive
2016-09-26 22:42 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926210724.GA16413@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=aditr@vmware.com \
--cc=asarwade@vmware.com \
--cc=bryantan@vmware.com \
--cc=dledford@redhat.com \
--cc=georgezhang@vmware.com \
--cc=jhansen@vmware.com \
--cc=leon@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.