From: Andrea Arcangeli <aarcange@redhat.com>
To: Shaun Tancheff <shaun@tancheff.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Ingo Molnar <mingo@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Chen Gang <gang.chen.5i5j@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mel Gorman <mgorman@techsingularity.net>,
Piotr Kwapulinski <kwapulinski.piotr@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Shaun Tancheff <shaun.tancheff@seagate.com>
Subject: Re: BUG Re: mm: vma_merge: fix vm_page_prot SMP race condition against rmap_walk
Date: Tue, 27 Sep 2016 18:05:29 +0200 [thread overview]
Message-ID: <20160927160529.GJ4618@redhat.com> (raw)
In-Reply-To: <CAJ48U8XgWQZBFuWt2Gk_5JAXz3wONgd15OmBY0M-Urq+_VGe9A@mail.gmail.com>
Hello,
On Tue, Sep 27, 2016 at 05:16:15AM -0500, Shaun Tancheff wrote:
> git bisect points at commit c9634dcf00c9c93b ("mm: vma_merge: fix
> vm_page_prot SMP race condition against rmap_walk")
I assume linux-next? But I can't find the commit, but I should know
what this is.
>
> Last lines to console are [transcribed]:
>
> vma ffff8c3d989a7c78 start 00007fe02ed4c000 end 00007fe02ed52000
> next ffff8c3d96de0c38 prev ffff8c3d989a6e40 mm ffff8c3d071cbac0
> prot 8000000000000025 anon_vma ffff8c3d96fc9b28 vm_ops (null)
> pgoff 7fe02ed4c file (null) private_data (null)
> flags: 0x8100073(read|write|mayread|maywrite|mayexec|account|softdirty)
It's a false positive, you have DEBUG_VM_RB=y, you can disable it or
cherry-pick the fix:
https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=74d8b44224f31153e23ca8a7f7f0700091f5a9b2
The assumption validate_mm_rb did isn't valid anymore on the new code
during __vma_unlink, the validation code must be updated to skip the
next vma instead of the current one after this change. It's a bug in
DEBUG_VM_RB=y, if you keep DEBUG_VM_RB=n there's no bug.
> Reproducer is an Ubuntu 16.04.1 LTS x86_64 running on a VM (VirtualBox).
> Symptom is a solid hang after boot and switch to starting gnome session.
>
> Hang at about 35s.
>
> kdbg traceback is all null entries.
>
> Let me know what additional information I can provide.
I already submitted the fix to Andrew last week:
https://marc.info/?l=linux-mm&m=147449253801920&w=2
I assume it's pending for merging in -mm.
If you can test this patch and confirm the problem goes away with
DEBUG_VM_RB=y it'd be great.
Thanks,
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrea Arcangeli <aarcange@redhat.com>
To: Shaun Tancheff <shaun@tancheff.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@suse.com>,
Ingo Molnar <mingo@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Chen Gang <gang.chen.5i5j@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mel Gorman <mgorman@techsingularity.net>,
Piotr Kwapulinski <kwapulinski.piotr@gmail.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Shaun Tancheff <shaun.tancheff@seagate.com>
Subject: Re: BUG Re: mm: vma_merge: fix vm_page_prot SMP race condition against rmap_walk
Date: Tue, 27 Sep 2016 18:05:29 +0200 [thread overview]
Message-ID: <20160927160529.GJ4618@redhat.com> (raw)
In-Reply-To: <CAJ48U8XgWQZBFuWt2Gk_5JAXz3wONgd15OmBY0M-Urq+_VGe9A@mail.gmail.com>
Hello,
On Tue, Sep 27, 2016 at 05:16:15AM -0500, Shaun Tancheff wrote:
> git bisect points at commit c9634dcf00c9c93b ("mm: vma_merge: fix
> vm_page_prot SMP race condition against rmap_walk")
I assume linux-next? But I can't find the commit, but I should know
what this is.
>
> Last lines to console are [transcribed]:
>
> vma ffff8c3d989a7c78 start 00007fe02ed4c000 end 00007fe02ed52000
> next ffff8c3d96de0c38 prev ffff8c3d989a6e40 mm ffff8c3d071cbac0
> prot 8000000000000025 anon_vma ffff8c3d96fc9b28 vm_ops (null)
> pgoff 7fe02ed4c file (null) private_data (null)
> flags: 0x8100073(read|write|mayread|maywrite|mayexec|account|softdirty)
It's a false positive, you have DEBUG_VM_RB=y, you can disable it or
cherry-pick the fix:
https://git.kernel.org/cgit/linux/kernel/git/andrea/aa.git/commit/?id=74d8b44224f31153e23ca8a7f7f0700091f5a9b2
The assumption validate_mm_rb did isn't valid anymore on the new code
during __vma_unlink, the validation code must be updated to skip the
next vma instead of the current one after this change. It's a bug in
DEBUG_VM_RB=y, if you keep DEBUG_VM_RB=n there's no bug.
> Reproducer is an Ubuntu 16.04.1 LTS x86_64 running on a VM (VirtualBox).
> Symptom is a solid hang after boot and switch to starting gnome session.
>
> Hang at about 35s.
>
> kdbg traceback is all null entries.
>
> Let me know what additional information I can provide.
I already submitted the fix to Andrew last week:
https://marc.info/?l=linux-mm&m=147449253801920&w=2
I assume it's pending for merging in -mm.
If you can test this patch and confirm the problem goes away with
DEBUG_VM_RB=y it'd be great.
Thanks,
Andrea
next prev parent reply other threads:[~2016-09-27 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 10:16 BUG Re: mm: vma_merge: fix vm_page_prot SMP race condition against rmap_walk Shaun Tancheff
2016-09-27 10:16 ` Shaun Tancheff
2016-09-27 16:05 ` Andrea Arcangeli [this message]
2016-09-27 16:05 ` Andrea Arcangeli
2016-09-27 20:05 ` Shaun Tancheff
2016-09-27 20:05 ` Shaun Tancheff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927160529.GJ4618@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=koct9i@gmail.com \
--cc=kwapulinski.piotr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=shaun.tancheff@seagate.com \
--cc=shaun@tancheff.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.