From: Martin Alonso <martin.alonso@zoho.com>
To: Joe Perches <joe@perches.com>
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
pasteka@kabsi.at, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Add spaces around '+' operator
Date: Tue, 27 Sep 2016 13:59:03 -0300 [thread overview]
Message-ID: <20160927165901.GA28955@malonso-pc> (raw)
In-Reply-To: <1474912953.2238.17.camel@perches.com>
On Mon, Sep 26, 2016 at 11:02:33AM -0700, Joe Perches wrote:
> On Mon, 2016-09-26 at 14:48 -0300, Martin Alonso wrote:
> > Fix coding style issue "spaces preferred around '+'
> > detected by checkpatch.pl in dpc.c file.
> []
> > diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c
> []
> > @@ -75,8 +75,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb,
> >
> > > skb_data = (u8 *)skb->data;
> >
> > - rx_sts = skb_data+4;
> > - rx_rate = skb_data+5;
> > + rx_sts = skb_data + 4;
> > + rx_rate = skb_data + 5;
> >
> > /* real Frame Size = USBframe_size -4WbkStatus - 4RxStatus */
> > /* -8TSF - 4RSR - 4SQ3 - ?Padding */
>
> You might as well make rx_rate u8 instead of u8 *
> and change the uses of rx_rate. rx_sts isn't used
> anywhere at all and could be removed.
>
I'll send two patches to fix this issues.
Regards.
next prev parent reply other threads:[~2016-09-27 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 17:48 [PATCH] staging: vt6656: Add spaces around '+' operator Martin Alonso
2016-09-26 18:02 ` Joe Perches
2016-09-27 16:59 ` Martin Alonso [this message]
2016-09-27 17:52 ` [PATCH 1/2] staging: vt6656: Remove unused variable 'rx_sts' Martin Alonso
2016-09-27 17:52 ` [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * Martin Alonso
2016-09-28 7:40 ` Dan Carpenter
2016-09-30 18:53 ` Malcolm Priestley
2016-09-30 19:37 ` Dan Carpenter
2016-09-28 9:34 ` Greg KH
2016-09-27 11:10 ` [PATCH] staging: vt6656: Add spaces around '+' operator Greg KH
2016-09-27 11:49 ` Martin Alonso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927165901.GA28955@malonso-pc \
--to=martin.alonso@zoho.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasteka@kabsi.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.